Re: [PATCH v2 RESEND] pstore/zone: Emit registration message as a single pr_info()
From: Sasha Levin
Date: Thu Nov 12 2026 - 10:24:27 EST
Two comments below, but not worth a respin for these.
On Fri, Jul 10, 2026 at 03:14:04PM +0530, Kartik Rajput wrote:
>@@ -1301,6 +1302,10 @@ int register_pstore_zone(struct pstore_zone_info *info)
> {
> int err = -EINVAL;
> struct psz_context *cxt = &pstore_zone_cxt;
>+ char buf[256];
The line can't get longer than about 50 characters, so 256 bytes of stack is a
lot.
>+ struct seq_buf s;
>+
>+ seq_buf_init(&s, buf, sizeof(buf));
DECLARE_SEQ_BUF(s, 64) would replace the buffer, the struct and this call with
one line.
Reviewed-by: Sasha Levin <sashal@xxxxxxxxxx>
--
Thanks,
Sasha