Re: [PATCH v2 3/9] MIPS: Ingenic: Do not force BUILTIN_DTB in Kconfig

From: H. Nikolaus Schaller

Date: Thu Nov 12 2026 - 10:34:24 EST




> Am 12.11.2026 um 14:57 schrieb Paul Cercueil <paul@xxxxxxxxxxxxxxx>:
>
> Hi Nikolaus,
>
> Le jeudi 12 novembre 2026 à 09:10 +0100, H. Nikolaus Schaller a écrit :
>> Remove the unconditional selection of BUILTIN_DTB for MACH_INGENIC
>> when MIPS_NO_APPENDED_DTB is enabled.
>>
>> The current Kconfig logic selects BUILTIN_DTB when
>> MIPS_NO_APPENDED_DTB is set, although this configuration is intended
>> to prevent the kernel from appending a DTB to the kernel image.
>>
>> While the kernel gives precedence to a DTB supplied by the boot loader,
>> selecting BUILTIN_DTB still triggers additional build steps and may
>> add unnecessary code to the resulting uImage.
>>
>> Note that BUILTIN_DTB controls the build process, not necessarily
>> whether a DTB is actually embedded in the kernel image. For example,
>> CONFIG_BUILTIN_DTB=y with CONFIG_BUILTIN_DTB_NAME="" still triggers
>> the generation of .builtin-dtbs.S, but does not embed a DTB.
>>
>> The goal is to allow a configuration in which no .builtin-dtbs.S
>> is generated and no DTB is appended to or built into the zImage/uImage.
>>
>> Fixes: f0f4a753079c ("MIPS: generic: Add support for Ingenic SoCs")
>> Fixes: 15205fc05482 ("MIPS: ingenic: Add support for appended devicetree")
>
> I don't think you can have two Fixes: tags...

Oops. Must be the result of mechanically squashing commits...

Will be fixed for V3.
>
> Cheers,
> -Paul

Same to you :)
Nikolaus

>
>> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
>> ---
>> arch/mips/Kconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
>> index 92bca520cd5ae..2135a69f9962c 100644
>> --- a/arch/mips/Kconfig
>> +++ b/arch/mips/Kconfig
>> @@ -127,7 +127,6 @@ config MACH_INGENIC
>> select GPIOLIB
>> select COMMON_CLK
>> select GENERIC_IRQ_CHIP
>> - select BUILTIN_DTB if MIPS_NO_APPENDED_DTB
>> select USE_OF
>> select CPU_SUPPORTS_CPUFREQ
>> select MIPS_EXTERNAL_TIMER