Re: [PATCH v4 05/13] arm64: renesas: r8a78000: Add FCPVD and VSPD nodes

From: Geert Uytterhoeven

Date: Thu Nov 12 2026 - 10:34:41 EST


Hi Paul,

On Mon, 9 Nov 2026 at 14:35, Paul Elder
<paul.elder+renesas@xxxxxxxxxxxxxxxx> wrote:
> Add DT nodes for the FCPVD and VSPD IP cores in the R-Car X5H SoC.
>
> Use the SGD1 clock as it is likely to be the clock used for data flow.
>
> Signed-off-by: Paul Elder <paul.elder+renesas@xxxxxxxxxxxxxxxx>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a78000.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a78000.dtsi
> @@ -1574,6 +1574,196 @@ mdlc_aon: system-controller@c1338000 {
> bootph-all;
> };
>
> + fcpvd0: fcp@c5010000 {

Please preserve sort order:
1. Sort by unit address,
2. Keep similar nodes together.

[...]

> + fcpvd9: fcp@c5019000 {

> + vspd0: vsp@c4800000 {

Do you want to sort the VSPs within the VSP group by unit address,
or by label?

By unit address:

"vspd0: vsp@c4800000"
"vspb0: vsp@c50c0000"

Note that adding the vspd* in a later patch than the vspb*
means the latter need to be moved in front of the fcp* :-(

By label:

"vspb0: vsp@c50c0000"
"vspd0: vsp@c4800000"

> + vspd1: vsp@c4808000 {

> + vspd2: vsp@c4810000 {

> + vspd3: vsp@c4818000 {

> + vspd4: vsp@c4820000 {

> + vspdb0: vsp@c4828000 {

> + vspdb1: vsp@c4830000 {

> + vspdb2: vsp@c4838000 {

> + vspdb3: vsp@c4840000 {

> + vspdb4: vsp@c4848000 {

> fcpvi0: fcp@c5030000 {

Shouldn't we keep al FCP nodes together?
Same for the VSP nodes.

> compatible = "renesas,fcpv";
> reg = <0 0xc5030000 0 0x1000>;

For the contents of the nodes (except for the renesas,fcp properties,
as I couldn't find the VSP<->FCP links in the documentation):
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds