Re: [PATCH] ALSA: hda/tas2781: Only accept CRC-less V1 data if all entries are valid
From: Gergo Koteles
Date: Thu Nov 12 2026 - 10:41:29 EST
Hi Mohamed,
On Thu, 2026-11-12 at 16:09 +0100, Mohamed Yassine JEBABLI wrote:
> Hi Gergo,
>
> Regarding the Q27/Q31/Q58 formats: they are not from any documentation; I
> inferred them from the data. Reading the first word of each entry as Q27
> gives a plausible speaker resistance (3.82 ohm on my Legion Pro 7, 3.64 ohm
> on Cristian's Yoga Pro 9), and reading the second word as Q31 gives exactly
> its reciprocal, within 1e-4, on both machines. So, for a consistent entry,
> R0 × InvR0 ~= 2^27 × 2^31 = 2^58.
>
> The V2 dump from the ASUS ROG Xbox Ally X thread (with a valid CRC) fits
> the same pattern: r0 = 0x3c5f7222 (~7.55 ohm in Q27) and invr0 = 0x10f615d5
> (~0.1325 in Q31, i.e. 1/7.55).
>
> My guess is Q5.27 and Q1.31, but I have no TI reference to confirm it.
>
> Finally, all testing was done on my own hardware: the original patch was
> tested on my Legion Pro 7 16IRX9H, and I reviewed and own the changes.
>
Ah okey, these are TI fixed point formats.
Thanks,
Gergo