Re: [PATCH v2] mm/slab: remove outdated comment in create_kmalloc_caches()

[Vlastimil Babka (SUSE)]

On 11/12/26 15:46, Sang-Heon Jeon wrote:
> Since commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h")
> removed SLAB, no kmalloc cache is created before create_kmalloc_caches().
> 
> So remove the outdated and redundant comment.
> 
> Signed-off-by: Sang-Heon Jeon <ekffu200098@xxxxxxxxx>

Reviewed-by: Vlastimil Babka (SUSE) <vbabka@xxxxxxxxxx>

> ---
> Changes from v1 [1]
> - Remove the whole useless comment
> 
> [1] https://lore.kernel.org/all/20261104144753.2266231-1-ekffu200098@xxxxxxxxx/
> 
> ---
>  mm/slab_common.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index 01c64ef661e7..10603b9cbb53 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -1028,11 +1028,6 @@ new_kmalloc_cache(int idx, enum kmalloc_cache_type type)
>  		kmalloc_caches[type][idx] = kmalloc_caches[type][aligned_idx];
>  }
>  
> -/*
> - * Create the kmalloc array. Some of the regular kmalloc arrays
> - * may already have been created because they were needed to
> - * enable allocations for slab creation.
> - */
>  void __init create_kmalloc_caches(void)
>  {
>  	int i;
> 
> base-commit: ce6518e61e3b4bf4f97f7ac6204049b9eba7eb75