Re: [PATCH v4 11/13] dt-bindings: Increase Renesas X5H MDLC PD specifier bit width
From: Geert Uytterhoeven
Date: Thu Nov 12 2026 - 10:47:27 EST
Hi Paul,
On Mon, 9 Nov 2026 at 14:35, Paul Elder
<paul.elder+renesas@xxxxxxxxxxxxxxxx> wrote:
> In the Renesas R-Car X5H, the module controller's power domain specifier
> cell's bit width has been increased. Update the bindings documentation
> to reflect this.
>
> Signed-off-by: Paul Elder <paul.elder+renesas@xxxxxxxxxxxxxxxx>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
Thanks for your patch!
> I'm guessing that the maximum number is now 512 but I can't find
> definite proof of this.
As the Module System Reset Registers are at offset 0x900 + l * 4,
and the Module System Reset Status Registers at offset 0x960 + l * 4,
there is room for 24 registers holding bitfields for 16 modules each,
thus maximum 384 modules.
> --- a/Documentation/devicetree/bindings/power/renesas,r8a78000-mdlc.yaml
> +++ b/Documentation/devicetree/bindings/power/renesas,r8a78000-mdlc.yaml
> @@ -12,7 +12,8 @@ maintainers:
> description:
> Each instance of the R-Car X5H Module Controller (MODULE CONTROL) provides
> Power Gating for up to 64 Power Domains, and Module Standby and Reset for up
> - to 256 modules in the Power Domain of each Module hierarchy.
> + to 256 modules in the Power Domain of each Module hierarchy. Recent hardware
> + versions have increased the number of supported modules.
Just change 256 to 384?
>
> properties:
> compatible:
> @@ -32,14 +33,14 @@ properties:
> are always on, and for which there are no MPDG bits to control them.
>
> - The second power domain specifier cell is the module standby part, and
> - must be the module number (0x00-0xff), composed of the Module System
> + must be the module number (0x00-0x1ff), composed of the Module System
0x17f
> Reset (MSRES) register index in the high nibble, and the Module Reset
> Destination bitfield index in the low nibble.
> const: 2
>
> '#reset-cells':
> description:
> - The single reset specifier cell must be the module number (0x00-0xff),
> + The single reset specifier cell must be the module number (0x00-0x1ff),
0x17f
> and thus identical to the second power domain specifier cell.
> const: 1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds