Re: [PATCH 2/2] wifi: ath12k: add GENERIC_MSI_IRQ dependency

From: Jeff Johnson

Date: Thu Nov 12 2026 - 11:59:29 EST


On 11/12/2026 1:26 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The platform_device_msi_init_and_alloc_irqs() interface can be disabled
> based on the configuration, though it is usually enabled. Without it,
> the driver now fails to build:
>
> drivers/net/wireless/ath/ath12k/pcic.c: In function 'ath12k_pcic_config_irq':
> drivers/net/wireless/ath/ath12k/pcic.c:387:15: error: implicit declaration of function 'platform_device_msi_init_and_alloc_irqs' [-Wimplicit-function-declaration]
> 387 | ret = platform_device_msi_init_and_alloc_irqs(&pdev->dev,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/ath/ath12k/pcic.c:424:9: error: implicit declaration of function 'platform_device_msi_free_irqs_all' [-Wimplicit-function-declaration]
> 424 | platform_device_msi_free_irqs_all(&pdev->dev);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Add a Kconfig dependency for it.
>
> Fixes: b9bc9ef941bd ("wifi: ath12k: Add platform MSI support for CE")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> Note that this patch applied cleanly on top of another Kconfig
> fix that I sent a while ago that is also still required,
> see
> https://lore.kernel.org/all/20260313094852.3716715-1-arnd@xxxxxxxxxx/
> ---
> drivers/net/wireless/ath/ath12k/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/ath/ath12k/Kconfig b/drivers/net/wireless/ath/ath12k/Kconfig
> index 4e8a301f2081..ed93ff36fbe2 100644
> --- a/drivers/net/wireless/ath/ath12k/Kconfig
> +++ b/drivers/net/wireless/ath/ath12k/Kconfig
> @@ -18,6 +18,7 @@ config ATH12K_AHB
> bool "Qualcomm ath12k AHB support"
> depends on ATH12K && REMOTEPROC
> depends on QCOM_RPROC_COMMON=y || ATH12K=m
> + depends on GENERIC_MSI_IRQ
> select QCOM_MDT_LOADER
> select QCOM_PAS
> help

Perhaps because I picked up the original of the 1st patch 'b4 ty' didn't thank
for this patch, but it has been picked up in my ath-next branch

/jeff