Re: [PATCH v2 0/2] Add struct_offsetofend() for pointer arithmetic
From: Kees Cook
Date: Thu Nov 12 2026 - 12:25:34 EST
On Thu, Nov 12, 2026 at 10:29:32AM +0100, Bence Csokas wrote:
> A common usage pattern for offsetof() is the following:
>
> offsetof(typeof(*ptr), member)
>
> This is exactly the definition of struct_offset(). Some call sites use
> offsetofend() instead of offsetof(). Add this variant, then replace all
> call sites with the corresponding macros.
Yeah, I think this is reasonable. I'd prefer to see the Coccinelle
script explicitly added to tools/coccinelle/api/ though, so it can be
trivially re-run as needed.
Also, while Alejandro is right about the needless outer parens, I think
I'd like to keep them just to match the other define, and they do no
harm.
-Kees
>
> Signed-off-by: Bence Csokas <bence.csokas@xxxxxxx>
> ---
> Changes in v2:
> - Use struct_offset() instead of reinventing it
> - Rename offsetofendp() to struct_offsetofend()
> - Merge the two treewide patches
> - Link to v1: https://patch.msgid.link/20261105-offsetof-v1-0-4153f5c10edc@xxxxxxx
>
> To: Kees Cook <kees@xxxxxxxxxx>
> To: "Gustavo A. R. Silva" <gustavoars@xxxxxxxxxx>
> To: Marcel Holtmann <marcel@xxxxxxxxxxxx>
> To: Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx>
> To: Sumit Semwal <sumit.semwal@xxxxxxxxxx>
> To: Christian König <christian.koenig@xxxxxxx>
> To: Philipp Stanner <phasta@xxxxxxxxxx>
> To: Sudeep Holla <sudeep.holla@xxxxxxxxxx>
> To: Cristian Marussi <cristian.marussi@xxxxxxx>
> To: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> To: Maxime Ripard <mripard@xxxxxxxxxx>
> To: Thomas Zimmermann <tzimmermann@xxxxxxx>
> To: David Airlie <airlied@xxxxxxxxx>
> To: Simona Vetter <simona@xxxxxxxx>
> To: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
> To: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> To: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
> To: Tvrtko Ursulin <tursulin@xxxxxxxxxxx>
> To: Lyude Paul <lyude@xxxxxxxxxx>
> To: Danilo Krummrich <dakr@xxxxxxxxxx>
> To: Zack Rusin <zack.rusin@xxxxxxxxxxxx>
> To: Broadcom internal kernel review list <bcm-kernel-feedback-list@xxxxxxxxxxxx>
> To: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx>
> To: Kalesh AP <kalesh-anakkur.purayil@xxxxxxxxxxxx>
> To: Jason Gunthorpe <jgg@xxxxxxxx>
> To: Leon Romanovsky <leon@xxxxxxxxxx>
> To: Chengchang Tang <tangchengchang@xxxxxxxxxx>
> To: Junxian Huang <huangjunxian6@xxxxxxxxxxxxx>
> To: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> To: Hans de Goede <hansg@xxxxxxxxxx>
> To: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> To: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> To: Wei Liu <wei.liu@xxxxxxxxxx>
> To: Dexuan Cui <decui@xxxxxxxxxxxxx>
> To: Andrew Lunn <andrew+netdev@xxxxxxx>
> To: "David S. Miller" <davem@xxxxxxxxxxxxx>
> To: Eric Dumazet <edumazet@xxxxxxxxxx>
> To: Jakub Kicinski <kuba@xxxxxxxxxx>
> To: Paolo Abeni <pabeni@xxxxxxxxxx>
> To: Miri Korenblit <miriam.rachel.korenblit@xxxxxxxxx>
> To: Jes Sorensen <Jes.Sorensen@xxxxxxxxx>
> To: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> To: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> To: Benson Leung <bleung@xxxxxxxxxxxx>
> To: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>
> To: Guenter Roeck <groeck@xxxxxxxxxxxx>
> To: Nilesh Javali <njavali@xxxxxxxxxxx>
> To: GR-QLogic-Storage-Upstream@xxxxxxxxxxx
> To: "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
> To: "Martin K. Petersen" <mkp@xxxxxxxxxx>
> Cc: linux-hardening@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-bluetooth@xxxxxxxxxxxxxxx
> Cc: linux-media@xxxxxxxxxxxxxxx
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: linaro-mm-sig@xxxxxxxxxxxxxxxx
> Cc: arm-scmi@xxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: nouveau@xxxxxxxxxxxxxxxxxxxxx
> Cc: linux-rdma@xxxxxxxxxxxxxxx
> Cc: linux-hyperv@xxxxxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx
> Cc: linux-wireless@xxxxxxxxxxxxxxx
> Cc: chrome-platform@xxxxxxxxxxxxxxx
> Cc: linux-scsi@xxxxxxxxxxxxxxx
>
> ---
> Bence Csokas (2):
> stddef: Add offsetofend() variant of struct_offset()
> treewide: Use struct_offset()
>
> drivers/bluetooth/btmrvl_main.c | 12 +++++-----
> drivers/dma-buf/dma-resv.c | 2 +-
> drivers/firmware/arm_scmi/base.c | 2 +-
> drivers/gpu/drm/drm_edid.c | 26 +++++++++++-----------
> drivers/gpu/drm/i915/gem/i915_gem_object.c | 4 ++--
> drivers/gpu/drm/i915/i915_active.c | 2 +-
> drivers/gpu/drm/i915/i915_sw_fence_work.c | 2 +-
> .../gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c | 2 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 12 +++++-----
> drivers/infiniband/hw/bnxt_re/qplib_fp.c | 2 +-
> drivers/infiniband/hw/hns/hns_roce_cq.c | 4 ++--
> drivers/infiniband/hw/hns/hns_roce_qp.c | 6 ++---
> drivers/media/usb/uvc/uvc_v4l2.c | 4 ++--
> drivers/net/hyperv/rndis_filter.c | 2 +-
> drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 2 +-
> drivers/net/wireless/intel/iwlwifi/mvm/rs-fw.c | 2 +-
> drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 2 +-
> .../net/wireless/intel/iwlwifi/pcie/ctxt-info-v2.c | 5 ++---
> drivers/net/wireless/realtek/rtl8xxxu/core.c | 2 +-
> drivers/net/wireless/realtek/rtw88/fw.c | 2 +-
> drivers/net/wireless/realtek/rtw89/core.c | 2 +-
> drivers/net/wireless/realtek/rtw89/fw.c | 8 +++----
> drivers/net/wireless/virtual/mac80211_hwsim_main.c | 4 ++--
> drivers/platform/chrome/cros_ec_lightbar.c | 4 ++--
> drivers/scsi/qla2xxx/qla_gs.c | 2 +-
> drivers/scsi/qla2xxx/qla_mbx.c | 2 +-
> drivers/scsi/qla2xxx/qla_os.c | 2 +-
> drivers/scsi/qla2xxx/qla_tmpl.c | 4 ++--
> drivers/scsi/scsi_transport_fc.c | 2 +-
> include/linux/overflow.h | 12 ++++++++++
> 30 files changed, 75 insertions(+), 64 deletions(-)
> ---
> base-commit: 9d66f26fefacebfeed15de31c1123451a17ff119
> change-id: 20261105-offsetof-f62aa6348f0d
>
> Best regards,
> --
> Bence Csokas <bence.csokas@xxxxxxx>
>
--
Kees Cook