Re: [PATCH] media: verisilicon: Replace strlcat() with seq_buf
From: Kees Cook
Date: Thu Nov 12 2026 - 13:03:52 EST
On Sun, Nov 08, 2026 at 08:08:00PM +0000, David Laight wrote:
> On Thu, 5 Nov 2026 00:45:18 -0800
> Mariia Nikitash <nikitash.mariiaw@xxxxxxxxx> wrote:
>
> > In preparation for removing the deprecated strlcat() API[1], replace
> > the strscpy() and strlcat() calls with seq_buf operations when
> > constructing Hantro video device names.
> >
> > This preserves the resulting strings, including truncation
> > when the compatible string and suffix exceed the destination
> > buffer's capacity.
>
> This is just stupid...
David, this isn't very helpful. I realize there are other threads where
you get into more detail, but as a stand-alone reply, I'd expect more
constructive feedback (or none at all, or a pointer to an earlier thread
if you feel like something needs repeating, etc).
--
Kees Cook