Re: [PATCH net 0/7] net: bcm4908_enet: TX ring and DMA fixes

From: Kordian Chmielewski

Date: Thu Nov 12 2026 - 13:08:29 EST


On Thu, 12 Nov 2026 09:13:23 -0800 Jakub Kicinski wrote:
> The AI review just got posted, please make sure you look thru it before
> sending v2.

Thanks, I went through it. The points on patches 1, 3 and 6 are right,
and v2 will fix them: the early ring-full stop in start_xmit() in
patch 1, the TX DMA that is not waited on before its buffers are freed
and the slot->skb race in patch 3, and the comment in patch 6.

I'll drop patch 7 rather than move it to net-next: its trigger is not
reachable with the driver's own settings, and dropping the frame did
not keep the DMA running anyway.

The review also found two older problems, a missing TX interrupt and a
failed RX refill. I'll send fixes for them separately, after this
series.

And I'll drop the nickname, as you asked.

I'll send v2 later today or tomorrow, once I've tested the changes on
the hardware.

Kordian