Re: [PATCH v2 4/6] riscv: checksum: Fix CC_HAS_ASM_GOTO_TIED_OUTPUT check

[Nathan Chancellor]

On Thu, Nov 12, 2026 at 12:26:32PM +0100, Nicolas Schier wrote:
> On Wed, Nov 11, 2026 at 05:52:06PM -0700, Nathan Chancellor wrote:
> > The defined symbol is CONFIG_CC_HAS_ASM_GOTO_TIED_OUTPUT, not
> > CC_HAS_ASM_GOTO_TIED_OUTPUT.
> > 
> > Fixes: 4525462dd0db ("riscv: lib: Check if output in asm goto supported")
> > Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> > ---
> > Cc: Charlie Jenkins <thecharlesjenkins@xxxxxxxxx>
> > Cc: Paul Walmsley <pjw@xxxxxxxxxx>
> > Cc: Palmer Dabbelt <palmer@xxxxxxxxxxx>
> > Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx
> > ---
> >  arch/riscv/lib/csum.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> 
> Thanks for catching!
> 
> Reviewed-by: Nicolas Schier <nsc@xxxxxxxxxx>
> 
> Since 4525462dd0db (v6.7) still supported clang-11: shall we add 'Cc: stable'?

I was a little on the fence about the 'Cc: stable'. On the one hand, it
is definitely a bug and it would totally qualify for stable. On the
other hand, nobody has noticed for almost three years and it is
exercising a new code path. I'll leave that up to you when you apply it
(or the RISC-V people can give their input as well).

-- 
Cheers,
Nathan