Re: [PATCH v2 1/4] clk: ti: fapll: remove ti_dt_clk_name helper
From: Andrew Goodbody
Date: Thu Nov 12 2026 - 13:23:30 EST
On 12/11/2026 01:12, Brian Masney wrote:
Maybe Rouven will step in here but the main thing is that fapll.c should never have been converted to use ti_dt_clk_name() as it does not work with the binding [1] and usage.The fapll driver uses multiple `clock-output-names`, so we cannot use the
DT helper in this driver because that would assign the first clock
output name as the parent name. This change do not affect other SoCs as
the only consumer is DM816x.
Fixes: 9e56a7d4263c ("clk: ti: Update pll and clockdomain clocks to use ti_dt_clk_name()")
Signed-off-by: Rouven Czerwinski <rouven.czerwinski@xxxxxxxxxx>
Tested-by: Andrew Goodbody <andrew.goodbody@xxxxxxxxxx>
Signed-off-by: Ettore Chimenti <ettore.chimenti@xxxxxxxxxx>
I see what you are doing here but can you give a more detailed commit
message / argument here in favor of the change to make it easier on
others that will evaluate this about whether or not it should be
backported to a different kernel.
Brian
eg with the node
main_fapll: main_fapll {
#clock-cells = <1>;
compatible = "ti,dm816-fapll-clock";
reg = <0x400 0x40>;
clocks = <&sys_clkin_ck &sys_clkin_ck>;
clock-indices = <1>, <2>, <3>, <4>, <5>,
<6>, <7>;
clock-output-names = "main_pll_clk1",
"main_pll_clk2",
"main_pll_clk3",
"main_pll_clk4",
"main_pll_clk5",
"main_pll_clk6",
"main_pll_clk7";
};
The use of ti_dt_clk_name() results in no attempt to register the clk main_fapll and duplicate attempts to register main_pll_clk1 of which the second fails leading to an early exit, the clk system is left not fully initialised and other problems follow with eg USB failing to init due to lack of clock.
Andrew
1. Documentation/devicetree/bindings/clock/ti/fapll.txt