Re: [PATCH v2 2/2] ASoC: codecs: Add driver for Iron Device MA5311

From: Mark Brown

Date: Thu Nov 12 2026 - 15:34:16 EST


On Thu, Nov 12, 2026 at 12:40:57AM +0000, Hyun-Uk Son wrote:

> > They rarely are, but they tend to be safe and what is suitable for
> > practical use will vary depending on the system. A gain that makes sense
> > for a line output will be unsuitable for headphones, and vice versa.
> > There are a few things, like zero cross for example, which are pretty much
> > universally sensible and we do change those but for things that are likely
> > to vary with use case we just go with what's in the hardware since that
> > gives us consistency without us making decisions that might favour some
> > users over others.

> I'd like to provide some additional context regarding the rationale behind
> the initialization values defined in reg_defaults.

> The purpose of this initialization is to configure the data path and output
> format for practical use, rather than to change sensitive parameters such as
> speaker volume, ADC gain, or PGA gain.

The trouble is that these parameters tend to be both sensitive and
platform specific - they'll depend on plastics, or the components in a
given system.

> The values of these parameters in reg_defaults match the hardware factory defaults.

Right, those are what the driver should nromally use.

Attachment: signature.asc
Description: PGP signature