Re: [PATCH v4 1/2] block: suspend bio based disks around queue limits updates
From: kernel test robot
Date: Thu Nov 12 2026 - 15:45:26 EST
Hi Jack,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4]
url: https://github.com/intel-lab-lkp/linux/commits/Jack-Wang/block-suspend-bio-based-disks-around-queue-limits-updates/20261112-144659
base: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
patch link: https://lore.kernel.org/r/20261112134700.372702-2-jinpu.wang%40cloud.ionos.com
patch subject: [PATCH v4 1/2] block: suspend bio based disks around queue limits updates
config: loongarch-defconfig (https://download.01.org/0day-ci/archive/20261113/202611130320.U910h0Q4-lkp@xxxxxxxxx/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 1b1fed44d3dcca649a9877915d57c3357a98124e)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261113/202611130320.U910h0Q4-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611130320.U910h0Q4-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
In file included from block/blk-integrity.c:18:
block/blk.h:680:10: warning: releasing mutex 'disk->queue->limits_lock' that was not held [-Wthread-safety-analysis]
680 | return queue_limits_commit_update(disk->queue, lim);
| ^
block/blk.h:681:9: warning: releasing mutex 'disk->queue->limits_lock' that was not held [-Wthread-safety-analysis]
681 | return queue_limits_commit_update_frozen(disk->queue, lim);
| ^
>> block/blk-integrity.c:255:1: warning: mutex '(dev - #undefined)->bd_disk->queue->limits_lock' is not held on every path through here [-Wthread-safety-analysis]
255 | }
| ^
block/blk-integrity.c:244:8: note: mutex acquired here
244 | lim = queue_limits_start_update(q);
| ^
3 warnings generated.
vim +255 block/blk-integrity.c
e9f5f44ad372533 Christoph Hellwig 2024-06-13 225
b83bd486b43d2b7 Kanchan Joshi 2024-06-17 226 static ssize_t flag_store(struct device *dev, const char *page, size_t count,
b83bd486b43d2b7 Kanchan Joshi 2024-06-17 227 unsigned char flag)
1366251a794b149 Christoph Hellwig 2024-06-13 228 {
9a7e3243fd42730 Jack Wang 2026-11-12 229 struct gendisk *disk = dev_to_disk(dev);
9a7e3243fd42730 Jack Wang 2026-11-12 230 struct request_queue *q = disk->queue;
c6e56cf6b2e79a4 Christoph Hellwig 2024-06-13 231 struct queue_limits lim;
1d59857ed2ec4d5 Christoph Hellwig 2024-06-13 232 unsigned long val;
1d59857ed2ec4d5 Christoph Hellwig 2024-06-13 233 int err;
1d59857ed2ec4d5 Christoph Hellwig 2024-06-13 234
1d59857ed2ec4d5 Christoph Hellwig 2024-06-13 235 err = kstrtoul(page, 10, &val);
1d59857ed2ec4d5 Christoph Hellwig 2024-06-13 236 if (err)
1d59857ed2ec4d5 Christoph Hellwig 2024-06-13 237 return err;
1366251a794b149 Christoph Hellwig 2024-06-13 238
9a7e3243fd42730 Jack Wang 2026-11-12 239 err = blk_disk_suspend(disk);
9a7e3243fd42730 Jack Wang 2026-11-12 240 if (err)
9a7e3243fd42730 Jack Wang 2026-11-12 241 return err;
9a7e3243fd42730 Jack Wang 2026-11-12 242
c6e56cf6b2e79a4 Christoph Hellwig 2024-06-13 243 /* note that the flags are inverted vs the values in the sysfs files */
c6e56cf6b2e79a4 Christoph Hellwig 2024-06-13 244 lim = queue_limits_start_update(q);
1366251a794b149 Christoph Hellwig 2024-06-13 245 if (val)
c6e56cf6b2e79a4 Christoph Hellwig 2024-06-13 246 lim.integrity.flags &= ~flag;
9f4aa46f2a74010 Christoph Hellwig 2024-06-13 247 else
c6e56cf6b2e79a4 Christoph Hellwig 2024-06-13 248 lim.integrity.flags |= flag;
c6e56cf6b2e79a4 Christoph Hellwig 2024-06-13 249
9a7e3243fd42730 Jack Wang 2026-11-12 250 err = blk_disk_commit_limits(disk, &lim);
9a7e3243fd42730 Jack Wang 2026-11-12 251 blk_disk_resume(disk);
c6e56cf6b2e79a4 Christoph Hellwig 2024-06-13 252 if (err)
c6e56cf6b2e79a4 Christoph Hellwig 2024-06-13 253 return err;
1366251a794b149 Christoph Hellwig 2024-06-13 254 return count;
1366251a794b149 Christoph Hellwig 2024-06-13 @255 }
1366251a794b149 Christoph Hellwig 2024-06-13 256
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki