Re: [PATCH net-next v10 06/12] net: dsa: realtek: rtl8365mb: refactor VLAN 4k handling

From: Linus Walleij

Date: Thu Nov 12 2026 - 16:02:07 EST


On Thu, Nov 12, 2026 at 6:36 PM Mieczyslaw Nalewaj <namiltd@xxxxxxxxx> wrote:

> Move the family-specific VLAN 4k table accessors behind struct
> rtl8365mb_family_info, so that family D can provide its own versions
> without is_d() checks in the shared code. The existing code becomes the
> family C implementation and is otherwise unchanged: rename the
> functions to rtl8365mb_c_vlan_4k_read() and rtl8365mb_c_vlan_4k_write(),
> export them and call them through the family info.
>
> No functional change.
>
> Tested-by: Gustavo Foletto Mora <gusfmora@xxxxxxxxx>
> Tested-by: Stanislaw Pal <kuncy7@xxxxxxxxx>
> Signed-off-by: Mieczyslaw Nalewaj <namiltd@xxxxxxxxx>

Looks good to me!
Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij