Re: [PATCH 02/13] drm: Discard pm_runtime_put_autosuspend() return values

[Doug Anderson]

Hi,

On Tue, Oct 6, 2026 at 4:19 PM Brian Norris <briannorris@xxxxxxxxxxxx> wrote:
>
> Several DRM drivers use or propagate the pm_runtime_put_autosuspend()
> return value, which is not particularly useful.
>
> Returning an error code from pm_runtime_put_autosuspend() merely means
> that it has not queued up a timer or work item to check whether or not
> the device can be suspended and there are many perfectly valid
> situations in which that can happen, like after writing "on" to the
> device's runtime PM "control" attribute in sysfs for one example.
>
> For this reason, modify these drivers to simply discard the
> pm_runtime_put_autosuspend() return value, and change the return type of
> v3d_pm_runtime_put() (whose return value is never used) to void.  Also
> drop the redundant pm_runtime_mark_last_busy() calls right before
> pm_runtime_put_autosuspend().
>
> This will facilitate a planned change of the
> pm_runtime_put_autosuspend() return type to void in the future, similar
> to commit 3afd8df02433 ("PM: runtime: Change pm_runtime_put() return
> type to void").
>
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
> ---
> This patch is independent of the rest of the series, except for the end
> (changing the return type). I expect it can be applied by individual
> maintainers, and we pick up the end once the dust is settled.
>
>  drivers/gpu/drm/panel/panel-simple.c | 8 +-------
>  drivers/gpu/drm/tidss/tidss_drv.c    | 7 +------
>  drivers/gpu/drm/v3d/v3d_drv.h        | 4 ++--
>  3 files changed, 4 insertions(+), 15 deletions(-)

FWIW, the hunk against tidss_drv.c goes away on the top of
drm-misc-next, since it's 100% identical to what landed in commit
2cc797f73768 ("drm/tidss: Drop WARN_ON() from tidss_runtime_put()").

The changes to the other two files look fine to me.

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

Pushed to drm-misc-next.

[02/13] drm: Discard pm_runtime_put_autosuspend() return values
        commit: c88084027d0e922dd925b96e5a0d184ba04a8f43

-Doug