Re: [PATCH v2] dt-bindings: phy: qcom: Relax required supplies

From: Rob Herring

Date: Thu Nov 12 2026 - 17:25:33 EST


On Thu, Nov 12, 2026 at 12:30 PM Bjorn Andersson <andersson@xxxxxxxxxx> wrote:
>
> On Thu, Nov 12, 2026 at 06:53:46AM -0600, Rob Herring wrote:
> > +Konrad
> >
> > On Thu, Nov 12, 2026 at 04:27:30PM +0530, Vinod Koul wrote:
> > > On 20-10-26, 21:24, Rob Herring (Arm) wrote:
> > > > For the QUSB2 PHY binding, keep the three regulator supplies required
> > > > except for legacy IPQ6018 nodes that do not describe the board rails.
> > > >
> > > > This relaxes the requirements for the IPQ5210 as well as if it is
> > > > compatible with IPQ6018, then it shouldn't have more required
> > > > properties either.
> > >
> > > Hey Rob,
> > >
> > > This fails for phy/next I see vdd-supply has been moved around..
> >
> > The change in question[1] should not be applied until the .dts changes
> > in the series are applied. It introduces a bunch of warnings.
>
> I don't understand. The change you present here relates to ipq5210 and
> ipq6018.
>
> That change doesn't touch these two IPQs, so what are you suggesting?
> Are we talking about the same warnings?

This is what I get with phy-next because it has the binding change
from [1], but not the .dts changes in the series:

arch/arm64/boot/dts/qcom/apq8096-db820c.dtb: phy@7411000
(qcom,msm8996-qusb2-phy): "power-domains" is a required property
from schema $id:
http://devicetree.org/schemas/phy/qcom,qusb2-phy.yaml
arch/arm64/boot/dts/qcom/apq8096-db820c.dtb: phy@7411000
(qcom,msm8996-qusb2-phy): "required-opps" is a required property
from schema $id:
http://devicetree.org/schemas/phy/qcom,qusb2-phy.yaml

(and then duplicated for every 8996 board).

> > Can the QCom folks stop doing that! Coordinate applying the series or
> > take the binding and dts changes in 1 tree.
>
> I assume you're referring to "QCom folks" in the sense "any maintainer
> touching a binding change related to a qcom platform"?

No, primarily you and the submitter I guess. Submitters should be
aware of dependencies in their series and suggest how things are
merged. Otherwise, it falls on you to care that warnings are getting
introduced.

I would not care so much when there are transient warnings in next,
but I don't want to be the one chasing them down. But AFAICT, it's
always me. No one beats me to it and I'm not all that fast in
noticing. I just compare all the warnings by platform for Linus vs.
next with "gl-diff-dtb-warning -p arm64" from this repo[2], and look
for things moving in the right direction. Of course this is all after
applying which isn't ideal.

> Do you have some CI/guidance/tooling for Vinod (and other subsystem
> maintainers) to perform system-wide DT-validation when considering
> merging a binding change?

This one is an ABI break because it adds new required properties. I do
have some tooling that looks for ABI changes, but haven't committed it
because I haven't figured out the best way to deploy it. I think for
anything that is an ABI change, the binding and dts files need to go
in together.

I think it is time to reconsider the default of bindings go in with
the driver. That works okay for new bindings as long as the platform
maintainer doesn't take .dts changes before bindings land (also an
issue). However, for cases like this, we need the opposite order. We
need to figure something out because this is only going to be more of
an issue as we get to warning free (and we are close).

> I unfortunately only spotted the one-way dependency when glancing at the
> seris and thereby ignored the dts patches waiting for the binding to be
> merged.
>
> > Given the patch series is 2+ months old, I'd be surprised if the rest
> > gets applied.
>
> I've applied the two dts changes today, and they do resolve a number of
> warnings - presumably the ones that you're talking about, but I don't
> think the ones that this patch aim to fix?

Other than the warnings it introduces, the [1] series fixes this one warning;

3 phy@7411000 (qcom,msm8996-qusb2-phy): "vdd-supply" is a
required property


> > This patch OTOH fixes warnings.
> >
>
> What warnings? Can you please provide actionable context when you're
> pointing out these issues.
>
> Is it the three "'x-supply' is a required property" warnings from
> ipq6018-cp01-c1.dtb? It seems unlikely that there's one chip that
> doesn't depend on those supplies.

Of your 20 unique warnings, it's these 10:

1 qusb@59000 (qcom,ipq6018-qusb2-phy): "vdd-supply" is a required property
1 qusb@59000 (qcom,ipq6018-qusb2-phy): "vdda-pll-supply" is a
required property
1 qusb@59000 (qcom,ipq6018-qusb2-phy): "vdda-phy-dpdm-supply" is
a required property
1 phy@79000 (qcom,ipq8074-qusb2-phy): "vdd-supply" is a required property
1 phy@79000 (qcom,ipq8074-qusb2-phy): "vdda-pll-supply" is a
required property
1 phy@79000 (qcom,ipq8074-qusb2-phy): "vdda-phy-dpdm-supply" is
a required property
1 phy@59000 (qcom,ipq8074-qusb2-phy): "vdd-supply" is a required property
1 phy@59000 (qcom,ipq8074-qusb2-phy): "vdda-pll-supply" is a
required property
1 phy@59000 (qcom,ipq8074-qusb2-phy): "vdda-phy-dpdm-supply" is
a required property

Rob

> > [1] https://lore.kernel.org/all/qusb2phy-v2-1-4c3f980a4560@xxxxxxxxxxxxxxxx

[2] https://gitlab.com/robherring/ci-jobs