Re: [PATCH v6 1/3] dt-bindings: mfd: rk8xx: add board level power hold GPIOs

[Rob Herring (Arm)]

On Sun, 01 Nov 2026 23:40:50 +0800, Yaozhong Li wrote:
> Some boards route "power hold" lines from the SoC into the board's power
> circuitry. Those lines have to be held asserted while the system is
> running and released before the PMIC shutdown request is written,
> otherwise the rails can drop and come back up instead of staying off.
> 
> Add power-hold-gpios to describe those lines and power-hold-delay-ms for
> the settle time. The driver reads them for every RK8xx variant that is
> the system power controller, so define them once, in a schema shared by
> the seven RK8xx bindings, and reference it from each. The bindings
> switch to unevaluatedProperties: false so that the shared properties are
> allowed, except rk817, which keeps additionalProperties: false and lists
> the two properties: it also references dai-common, of which it only
> allows a subset.
> 
> The array is bounded at two entries. Firefly's vendor kernel handles
> exactly two such lines, pmic,hold-gpio and pmic,stby-gpio, and its board
> files use one or both of them, with an RK808 and with an RK818.
> 
> The lines are released from the PMIC's power-off path, so they are only
> meaningful when the PMIC is the system power controller. Require that.
> A board adding these lines is expected to switch to the generic
> system-power-controller property at the same time, so the deprecated
> rockchip,system-power-controller spelling is not accepted here.
> 
> Assisted-by: LLM
> Signed-off-by: Yaozhong Li <yaozhonguwl@xxxxxxxxx>
> ---
>  .../bindings/mfd/rockchip,rk801.yaml          |  5 ++-
>  .../bindings/mfd/rockchip,rk805.yaml          |  3 +-
>  .../bindings/mfd/rockchip,rk806.yaml          |  1 +
>  .../bindings/mfd/rockchip,rk808.yaml          |  5 ++-
>  .../bindings/mfd/rockchip,rk816.yaml          |  5 ++-
>  .../bindings/mfd/rockchip,rk817.yaml          |  4 ++
>  .../bindings/mfd/rockchip,rk818.yaml          |  5 ++-
>  .../mfd/rockchip,rk8xx-power-hold.yaml        | 42 +++++++++++++++++++
>  8 files changed, 65 insertions(+), 5 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk8xx-power-hold.yaml
> 

Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>