Re: [PATCH v2 1/4] dt-bindings: clock: Add Siflower SF19A2890 clock manager

From: Joseph Telaak

Date: Thu Nov 12 2026 - 18:26:29 EST


> > +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
>
> The license is different compared to siflower,sf19a2890-clk.yaml. Is that
> expected?

Yes. The header is Chuanhong's, and it keeps the license he gave it,
with only the identifier updated from GPL-2.0 to GPL-2.0-only. The
binding is mine, under the usual GPL-2.0-only OR BSD-2-Clause. Both
licenses let non-GPL device trees use the header.

> > +#define CLK_MUXDIV_NPU_PE_CLK 20
>
> This is the only one that has a suffix of _CLK. Can that be dropped for
> consistency?

Sure, v3 names it CLK_MUXDIV_NPU_PE. No device tree uses it yet.

Thanks,
Joseph