Re: [PATCH v2 2/2] power: supply: Add GL.iNet GL-E750 MCU battery driver
From: servpol
Date: Thu Nov 12 2026 - 18:48:28 EST
On Mon, Nov 09, 2026 at 12:35:58AM +0100, Sebastian Reichel wrote:
> The Sashiko analysis looks correct:
>
> https://sashiko.dev/#/patchset/20261005-gl-e750-mcu-v1-0-499d2e31f786%40tuta.io
Hi Sebastian,
thanks for looking at it. That link is the review of v1, and both
findings there are addressed in this v2 (see "Changes in v2" in the
cover letter):
- a new message (they all start with '{') now ends the previous one,
so an event that follows a status reply without a line ending is no
longer appended to it and lost;
- the poll work no longer clears the receive buffer, neither before the
request nor on the reply timeout; it only consumes a pending status
reply, so a partially received event stays in the buffer.
Sashiko's review of v2 reports no regressions:
https://sashiko.dev/#/patchset/20261021-gl-e750-mcu-v2-0-9bd7e7c2e0e1%40tuta.io
If you meant something else in that analysis, please let me know and
I'll address it in v3.
Thanks,
Serv