[PATCH RFC 03/13] drm/gma500: Export GEM objects as dma-bufs

From: Joseph Telaak

Date: Thu Nov 12 2026 - 19:02:08 EST


A render GPU next to gma500 draws into gma500's scanout buffers: on
Cedarview the SGX545, driven by powervr_sgx through gma500's auxiliary
device, renders while gma500 scans out. Mesa's kmsro allocates the
buffers on the display device and imports them into the render device,
which needs gma500 to export them.

Add the pin, unpin, get_sg_table, vmap and vunmap hooks the PRIME
helpers need. An export pins the object's pages, write-combined as for a
framebuffer, but doesn't insert them into the GTT: the importer maps the
pages itself, and powervr_sgx takes a write-combined kernel mapping of
an import for its cache maintenance. (A CPU mmap through
dma_buf_mmap() still goes through psb_gem_fault(), which pins the object
into the GTT.) A use count shares the pages between GTT pins, exports
and kernel mappings. Objects in stolen memory have no struct pages and
can't be exported.

The PRIME helpers call pin and unpin with the object's reservation lock
held, and psb_gem_pin() and psb_gem_unpin() take that lock themselves.
Split each into a variant that expects the lock held.

The importer's CPU mapping, dma_buf_mmap(), goes through the object's
fake mmap offset, which a dumb buffer only gets from MAP_DUMB, and Mesa's
kmsro never calls that for the buffers it exports. Create the offset at
export.

Signed-off-by: Joseph Telaak <joseph@xxxxxxxxxx>
---
drivers/gpu/drm/gma500/gem.c | 182 ++++++++++++++++++++++++++++++++++++-------
drivers/gpu/drm/gma500/gem.h | 1 +
2 files changed, 153 insertions(+), 30 deletions(-)

diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c
index 4a4ecfb7b..9eff7a739 100644
--- a/drivers/gpu/drm/gma500/gem.c
+++ b/drivers/gpu/drm/gma500/gem.c
@@ -11,11 +11,14 @@
* accelerated operations on a GEM object)
*/

+#include <linux/iosys-map.h>
#include <linux/pagemap.h>
+#include <linux/vmalloc.h>

#include <asm/set_memory.h>

#include <drm/drm.h>
+#include <drm/drm_prime.h>
#include <drm/drm_print.h>
#include <drm/drm_vma_manager.h>

@@ -26,71 +29,104 @@
* PSB GEM object
*/

-int psb_gem_pin(struct psb_gem_object *pobj)
+/*
+ * The object's pages, write-combined, for a GART pin or a PRIME export: an
+ * exported object needs them, not a slot in the small GTT aperture.
+ */
+static int psb_gem_get_pages_locked(struct psb_gem_object *pobj)
+{
+ struct drm_gem_object *obj = &pobj->base;
+ struct page **pages;
+
+ dma_resv_assert_held(obj->resv);
+
+ if (pobj->pages_use++)
+ return 0;
+ pages = drm_gem_get_pages(obj);
+ if (IS_ERR(pages)) {
+ pobj->pages_use--;
+ return PTR_ERR(pages);
+ }
+ set_pages_array_wc(pages, obj->size / PAGE_SIZE);
+ pobj->pages = pages;
+ return 0;
+}
+
+static void psb_gem_put_pages_locked(struct psb_gem_object *pobj)
+{
+ struct drm_gem_object *obj = &pobj->base;
+
+ dma_resv_assert_held(obj->resv);
+
+ if (WARN_ON(!pobj->pages_use) || --pobj->pages_use)
+ return;
+ /* Reset caching flags */
+ set_pages_array_wb(pobj->pages, obj->size / PAGE_SIZE);
+ drm_gem_put_pages(obj, pobj->pages, true, false);
+ pobj->pages = NULL;
+}
+
+static int psb_gem_pin_locked(struct psb_gem_object *pobj)
{
struct drm_gem_object *obj = &pobj->base;
struct drm_device *dev = obj->dev;
struct drm_psb_private *dev_priv = to_drm_psb_private(dev);
u32 gpu_base = dev_priv->gtt.gatt_start;
- struct page **pages;
unsigned int npages;
int ret;

- ret = dma_resv_lock(obj->resv, NULL);
- if (drm_WARN_ONCE(dev, ret, "dma_resv_lock() failed, ret=%d\n", ret))
- return ret;
+ dma_resv_assert_held(obj->resv);

if (pobj->in_gart || pobj->stolen)
goto out; /* already mapped */

- pages = drm_gem_get_pages(obj);
- if (IS_ERR(pages)) {
- ret = PTR_ERR(pages);
- goto err_dma_resv_unlock;
- }
+ ret = psb_gem_get_pages_locked(pobj);
+ if (ret)
+ return ret;

npages = obj->size / PAGE_SIZE;

- set_pages_array_wc(pages, npages);
-
- psb_gtt_insert_pages(dev_priv, &pobj->resource, pages);
+ psb_gtt_insert_pages(dev_priv, &pobj->resource, pobj->pages);
if (dev_priv->mmu)
- psb_mmu_insert_pages(psb_mmu_get_default_pd(dev_priv->mmu), pages,
+ psb_mmu_insert_pages(psb_mmu_get_default_pd(dev_priv->mmu), pobj->pages,
(gpu_base + pobj->offset), npages, 0, 0,
PSB_MMU_CACHED_MEMORY);

- pobj->pages = pages;
-
out:
++pobj->in_gart;
- dma_resv_unlock(obj->resv);
-
return 0;
+}
+
+int psb_gem_pin(struct psb_gem_object *pobj)
+{
+ struct drm_gem_object *obj = &pobj->base;
+ int ret;

-err_dma_resv_unlock:
+ ret = dma_resv_lock(obj->resv, NULL);
+ if (drm_WARN_ONCE(obj->dev, ret, "dma_resv_lock() failed, ret=%d\n", ret))
+ return ret;
+ ret = psb_gem_pin_locked(pobj);
dma_resv_unlock(obj->resv);
+
return ret;
}

-void psb_gem_unpin(struct psb_gem_object *pobj)
+static void psb_gem_unpin_locked(struct psb_gem_object *pobj)
{
struct drm_gem_object *obj = &pobj->base;
struct drm_device *dev = obj->dev;
struct drm_psb_private *dev_priv = to_drm_psb_private(dev);
u32 gpu_base = dev_priv->gtt.gatt_start;
unsigned long npages;
- int ret;

- ret = dma_resv_lock(obj->resv, NULL);
- if (drm_WARN_ONCE(dev, ret, "dma_resv_lock() failed, ret=%d\n", ret))
- return;
+ dma_resv_assert_held(obj->resv);

WARN_ON(!pobj->in_gart);

--pobj->in_gart;

if (pobj->in_gart || pobj->stolen)
- goto out;
+ return;

npages = obj->size / PAGE_SIZE;

@@ -99,13 +135,18 @@ void psb_gem_unpin(struct psb_gem_object *pobj)
(gpu_base + pobj->offset), npages, 0, 0);
psb_gtt_remove_pages(dev_priv, &pobj->resource);

- /* Reset caching flags */
- set_pages_array_wb(pobj->pages, npages);
+ psb_gem_put_pages_locked(pobj);
+}

- drm_gem_put_pages(obj, pobj->pages, true, false);
- pobj->pages = NULL;
+void psb_gem_unpin(struct psb_gem_object *pobj)
+{
+ struct drm_gem_object *obj = &pobj->base;
+ int ret;

-out:
+ ret = dma_resv_lock(obj->resv, NULL);
+ if (drm_WARN_ONCE(obj->dev, ret, "dma_resv_lock() failed, ret=%d\n", ret))
+ return;
+ psb_gem_unpin_locked(pobj);
dma_resv_unlock(obj->resv);
}

@@ -133,8 +174,89 @@ static const struct vm_operations_struct psb_gem_vm_ops = {
.close = drm_gem_vm_close,
};

+/*
+ * PRIME export, for a render GPU to draw into scanout buffers. Only objects
+ * with pages can be shared: stolen memory has none. An export pins the pages,
+ * write-combined, and doesn't insert them into the GTT. The PRIME helpers
+ * call pin and unpin with the reservation lock held.
+ */
+static int psb_gem_prime_pin(struct drm_gem_object *obj)
+{
+ struct psb_gem_object *pobj = to_psb_gem_object(obj);
+
+ if (pobj->stolen)
+ return -EINVAL;
+ return psb_gem_get_pages_locked(pobj);
+}
+
+static void psb_gem_prime_unpin(struct drm_gem_object *obj)
+{
+ psb_gem_put_pages_locked(to_psb_gem_object(obj));
+}
+
+static struct sg_table *psb_gem_prime_get_sg_table(struct drm_gem_object *obj)
+{
+ struct psb_gem_object *pobj = to_psb_gem_object(obj);
+
+ if (!pobj->pages)
+ return ERR_PTR(-EINVAL);
+ return drm_prime_pages_to_sg(obj->dev, pobj->pages, obj->size >> PAGE_SHIFT);
+}
+
+/*
+ * A kernel mapping for an importer, write-combined like the pages. It holds
+ * the pages as a PRIME pin does. The PRIME helpers call it with the
+ * reservation lock held.
+ */
+static int psb_gem_prime_vmap(struct drm_gem_object *obj, struct iosys_map *map)
+{
+ struct psb_gem_object *pobj = to_psb_gem_object(obj);
+ void *vaddr;
+ int ret;
+
+ if (pobj->stolen)
+ return -EINVAL;
+ ret = psb_gem_get_pages_locked(pobj);
+ if (ret)
+ return ret;
+ vaddr = vmap(pobj->pages, obj->size >> PAGE_SHIFT, VM_MAP,
+ pgprot_writecombine(PAGE_KERNEL));
+ if (!vaddr) {
+ psb_gem_put_pages_locked(pobj);
+ return -ENOMEM;
+ }
+ iosys_map_set_vaddr(map, vaddr);
+ return 0;
+}
+
+static void psb_gem_prime_vunmap(struct drm_gem_object *obj, struct iosys_map *map)
+{
+ vunmap(map->vaddr);
+ psb_gem_put_pages_locked(to_psb_gem_object(obj));
+}
+
+/*
+ * dma_buf_mmap() maps through the object's fake offset (drm_gem_prime_mmap()),
+ * which a dumb buffer only gets from MAP_DUMB: make sure it has one.
+ */
+static struct dma_buf *psb_gem_prime_export(struct drm_gem_object *obj, int flags)
+{
+ int ret;
+
+ ret = drm_gem_create_mmap_offset(obj);
+ if (ret)
+ return ERR_PTR(ret);
+ return drm_gem_prime_export(obj, flags);
+}
+
static const struct drm_gem_object_funcs psb_gem_object_funcs = {
.free = psb_gem_free_object,
+ .export = psb_gem_prime_export,
+ .pin = psb_gem_prime_pin,
+ .unpin = psb_gem_prime_unpin,
+ .get_sg_table = psb_gem_prime_get_sg_table,
+ .vmap = psb_gem_prime_vmap,
+ .vunmap = psb_gem_prime_vunmap,
.vm_ops = &psb_gem_vm_ops,
};

diff --git a/drivers/gpu/drm/gma500/gem.h b/drivers/gpu/drm/gma500/gem.h
index 27df6ff4e..539f8f20a 100644
--- a/drivers/gpu/drm/gma500/gem.h
+++ b/drivers/gpu/drm/gma500/gem.h
@@ -27,6 +27,7 @@ struct psb_gem_object {
bool stolen; /* Backed from stolen RAM */
bool mmapping; /* Is mmappable */
struct page **pages; /* Backing pages if present */
+ unsigned int pages_use; /* GART pins and PRIME pins of @pages */
};

static inline struct psb_gem_object *to_psb_gem_object(struct drm_gem_object *obj)

--
2.50.1