Re: [PATCH v10 05/15] media: ov8858: Add INT3477 ACPI ID

From: Sakari Ailus

Date: Thu Nov 12 2026 - 19:56:59 EST


Hi Maurizio,

On Fri, Oct 02, 2026 at 10:57:43AM +0200, Maurizio Casciano via B4 Relay wrote:
> From: Maurizio Casciano <mauriziocasciano7@xxxxxxxxx>
>
> Firmware may use INT3477 as the ACPI hardware ID for an OV8858 image
> sensor. Add an ACPI match table for that ID.
>
> Signed-off-by: Maurizio Casciano <mauriziocasciano7@xxxxxxxxx>
> ---
> drivers/media/i2c/ov8858.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/media/i2c/ov8858.c b/drivers/media/i2c/ov8858.c
> index 64532237e8b5..c747ecd9e908 100644
> --- a/drivers/media/i2c/ov8858.c
> +++ b/drivers/media/i2c/ov8858.c
> @@ -6,6 +6,7 @@
> * Copyright (c) 2017 Intel Corporation.
> */
>
> +#include <linux/acpi.h>
> #include <linux/clk.h>
> #include <linux/delay.h>
> #include <linux/device.h>
> @@ -2093,6 +2094,12 @@ static void ov8858_remove(struct i2c_client *client)
> pm_runtime_set_suspended(&client->dev);
> }
>
> +static const struct acpi_device_id ov8858_acpi_match[] = {
> + { .id = "INT3477" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(acpi, ov8858_acpi_match);

An ACPI ID table in this driver has been added by commit 41a9840e0caf5 .
Please rebase.

> +
> static const struct of_device_id ov8858_of_match[] = {
> { .compatible = "ovti,ov8858" },
> { /* sentinel */ },
> @@ -2103,6 +2110,7 @@ static struct i2c_driver ov8858_i2c_driver = {
> .driver = {
> .name = "ov8858",
> .pm = &ov8858_pm_ops,
> + .acpi_match_table = ACPI_PTR(ov8858_acpi_match),
> .of_match_table = ov8858_of_match,
> },
> .probe = ov8858_probe,
>

--
Regards,

Sakari Ailus