[PATCH 0/3] usb: uas / scsi: fail inflight and queued commands on dead links
From: Sarthak Kukreti
Date: Thu Nov 12 2026 - 20:10:16 EST
Unplugging a UAS device during system suspend after hub_wq is frozen
defers usb_disconnect() until hub_wq thaws. When sd_suspend_system()
issues SYNCHRONIZE_CACHE to the disconnected target:
1. If the HCD accepts the URBs, the status URB fails in uas_stat_cmplt()
without completing inflight commands, stranding SYNCHRONIZE_CACHE for
the 60s SCSI timeout and triggering the 25s DPM watchdog. Patch 1
completes inflight commands with DID_NO_CONNECT on non-unlink status
URB errors, unlinks inflight data URBs, and preserves non-DID_OK host
bytes in uas_data_cmplt().
2. If usb_submit_urb() fails with -ESHUTDOWN, -ENOENT, or -EHOSTUNREACH,
uas_queuecommand_lck() requeues the command instead of failing it,
and leaks unsubmitted URBs if status URB submission succeeded first.
Patch 2 fails the command with DID_NO_CONNECT and frees unsubmitted
URBs.
3. When the command completes with DID_NO_CONNECT,
scsi_check_passthrough() matches SCMD_FAILURE_RESULT_ANY and retries
it against the disconnected target. Patch 3 skips retries on
DID_NO_CONNECT, DID_BAD_TARGET, and DID_TRANSPORT_FAILFAST.
Tested using a USB/IP (vhci_hcd) UAS target emulator that freezes
hub_wq, injects -EPROTO on the status URB during inflight
SYNCHRONIZE_CACHE and READ(10) commands, and verifies immediate
DID_NO_CONNECT completion without retries or DPM watchdog timeouts,
along with the scsi_lib KUnit test suite.
Sarthak Kukreti (3):
usb: uas: complete inflight commands on status URB error
usb: uas: fail command submission on fatal USB errors
scsi: core: do not retry passthrough requests on disconnected targets
drivers/scsi/scsi_lib.c | 5 ++++
drivers/scsi/scsi_lib_test.c | 9 ++++++-
drivers/usb/storage/uas.c | 51 +++++++++++++++++++++++++++++++++---
3 files changed, 60 insertions(+), 5 deletions(-)
--
2.56.0.611.g1030f0b940-goog