Re: [PATCH 3/5] iio: adc: qcom-spmi-adc5: Add ADC5_BAT_THERM_100K_PU
From: Jonathan Cameron
Date: Thu Nov 12 2026 - 20:22:55 EST
On Thu, 12 Nov 2026 14:07:29 -0300
Val Packett <val@xxxxxxxxxxxx> wrote:
> Even though it existed in bindings for the longest time,
> ADC5_BAT_THERM_100K_PU was never assigned in the driver. Do so.
>
> Signed-off-by: Val Packett <val@xxxxxxxxxxxx>
> ---
> drivers/iio/adc/qcom-spmi-adc5.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c
> index d57ba8526e0c..c27ff89429f5 100644
> --- a/drivers/iio/adc/qcom-spmi-adc5.c
> +++ b/drivers/iio/adc/qcom-spmi-adc5.c
> @@ -542,6 +542,8 @@ static const struct adc5_channels adc5_chans_pmic[ADC5_MAX_CHANNEL] = {
> SCALE_HW_CALIB_DEFAULT)
> [ADC5_XO_THERM_100K_PU] = ADC5_CHAN_TEMP("xo_therm", 0,
> SCALE_HW_CALIB_XOTHERM)
> + [ADC5_BAT_THERM_100K_PU] = ADC5_CHAN_TEMP("bat_therm", 0,
> + SCALE_HW_CALIB_THERM_100K_PULLUP)
Whilst alignment isn't exactly consistent, this should probably match
the one two down that has same number of chars in the _PU] bit.
So use a space rather than a tab.
Otherwise seems fine to me.
> [ADC5_BAT_ID_100K_PU] = ADC5_CHAN_TEMP("bat_id", 0,
> SCALE_HW_CALIB_DEFAULT)
> [ADC5_AMUX_THM1_100K_PU] = ADC5_CHAN_TEMP("amux_thm1_100k_pu", 0,