Re: [PATCH net-next v10 03/12] net: dsa: realtek: rtl8365mb: refactor forcemode handling

From: Linus Walleij

Date: Thu Nov 12 2026 - 20:47:07 EST


On Thu, Nov 12, 2026 at 6:33 PM Mieczyslaw Nalewaj <namiltd@xxxxxxxxx> wrote:

> Move the external interface force-mode configuration behind struct
> rtl8365mb_family_info, so that family D can provide its own versions
> without is_d() checks in the shared code. The existing code becomes
> the family C implementation and is otherwise unchanged. The
> mac_link_up() and mac_link_down() callbacks call it through the family
> info.
>
> No functional change.
>
> Tested-by: Gustavo Foletto Mora <gusfmora@xxxxxxxxx>
> Tested-by: Stanislaw Pal <kuncy7@xxxxxxxxx>
> Signed-off-by: Mieczyslaw Nalewaj <namiltd@xxxxxxxxx>

Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij