Re: [PATCH v2 13/24] PCI: dwc: Add ZTE ZX279128S host controller driver

From: Navid Ghahremani

Date: Thu Nov 12 2026 - 20:53:49 EST


Hi Bjorn,

Bjorn Helgaas wrote:
> Suggest making the subject line:
>
> PCI: zx: Add ...
>
> or whatever tag you plan to use for the family of hardware this driver
> will support over time. Future changes to a driver typically don't
> include "dwc" because the name of the driver itself is more useful.
>
> I see "zx" used in the spi patch and "zte" used in the clk patch.
> "zte" might be too generic; there may be future hardware that requires
> a different driver. "zx279128s" might be too specific; there will
> likely be more SoCs that share this driver. Same consideration
> applies to filename, config symbol, struct and function names, etc.

Thanks. I will use zx for all of them in the PCIe series, so the
subject PCI: zx:, pcie-zx.c, CONFIG_PCIE_ZX, struct zx_pcie and the
zx_pcie_* functions.

> Capitalization of "zx279128s" here (menu item, help text, comment
> below) should probably match the commit log and marketing materials
> for this SoC.

Stefan suggested lower case for these SoC names in a reply, so I will
write zx279128s in the commit log as well and the two will match.

Best regards,
Navid