Re: [PATCH net v6] kcm: reject attaching sockets with a ULP, and TLS on KCM sockets
From: Rishikesh Jethwani
Date: Thu Nov 12 2026 - 21:12:14 EST
On Tue, Nov 10, 2026 at 1:12 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Wed, 4 Nov 2026 11:34:42 -0700 Rishikesh Jethwani wrote:
> > Holding a ULP also has visible side effects: getsockopt(TCP_ULP)
>
> This part does not feel right to me. It's not a real ULP yet we will
> start announcing it via all the ULP uAPI.
>
> If you repost please try to trim the commit message and the
> documentation slop.
Agreed. I'll replace the dummy ULP with a bool in struct tcp_sock
under IS_ENABLED(CONFIG_AF_KCM).
KCM sets it on attach and clears it on detach; tls_init() checks it
under the same socket lock.
KCM still rejects an existing ULP, without appearing in the ULP UAPI.
I'll also trim the commit message and documentation.
> --
> pw-bot: cr