Re: [PATCH v1 10/10] kconfig: Introduce OVERLAY= for make checkconfig

[Ahmed S. Darwish]

Hi Nicolas,

On Thu, 12 Nov 2026, Ahmed S. Darwish wrote:
>
> On Wed, 11 Nov 2026, Nicolas Schier wrote:
> >
> > Please add the optional overlay arguments right here:
> >
> > 	$(Q)$(checkconfig) check -r "$(RULES)" -c "$(KCONFIG_CONFIG)" $(addprefix -o , "$(OVERLAY)")
> >
>
> Sure, will do.
>

I've just tried the suggested addprefix function:

    $ make V=1 RULES=preempt_rt checkconfig
    ...
    python3 -B ./tools/kconfig-check/check.py check -c ".config" -p "preempt_rt" -o ""

Notice the breakage due to -o "".

Unquoting OVERLAY will make it work:

    $(Q)$(checkconfig) check -r "$(RULES)" -c "$(KCONFIG_CONFIG)" $(addprefix -o , $(OVERLAY))

But it breaks the consistent pattern of quoting all passed variables.

So, can we keep it as it was originally done?

Namely:

    checkconfig_overlay = $(if $(OVERLAY),-o "$(OVERLAY)")
    ...

    checkconfig:
	...
	$(Q)$(checkconfig) check -r "$(RULES)" -c "$(KCONFIG_CONFIG)" $(checkconfig_overlay)

Thanks!

--
Ahmed S. Darwish
Linutronix GmbH