Re: [PATCH v2 06/24] clk: zte: Add ZX279128S CRM clock and reset driver
From: Navid Ghahremani
Date: Thu Nov 12 2026 - 22:18:48 EST
Hi Stefan,
Stefan Dösinger wrote:
> The comments I sent for v1 still apply to v2 I think.
You are right. In my reply on the RFC I wrote that your points were
done in v2, and for the clock driver that was wrong. It still had its
own PLL code, direct MMIO and its own lock, and the resets were still
in drivers/clk.
> Please try to reuse the infrastructure in place for zx29. Ideally clk-
> zx279128s.c should be just static data and a minimalistic _probe function that
> invokes zx_clk_common_probe().
That is how the next version will do it, on v7.4-rc1, with static data
for the regmap clocks and pll-zx.c, a short probe that calls
zx_clk_common_probe() and the resets in a separate reset driver. My
question about the MFD and reset layout is in my reply to the cover
letter.
Best regards,
Navid