Re: [PATCH v2 11/24] phy: zte: Add ZTE ZX279128S PCIe PHY driver
From: Navid Ghahremani
Date: Fri Nov 13 2026 - 00:08:28 EST
Hi Agustin,
Agustin Santiago wrote:
> On my unit both read back 0 after boot: there seems to be no register
> at 0x1b0/0x1b4 in the top CRM. The vendor kernel writes these two
> values into the port 1 controller's "ctrl" window instead
> (0x09600000 + 0x1b4, then + 0x1b0); with this series those read
> 0x00203c78 / 0x0c46c24a. The link trains anyway (the MT7916 enumerates
> at 2.5 GT/s), so it may only matter for signal margin, but as written
> the writes have no effect.
You are right, thank you. I checked the stock kernel and it maps
0x09600000 for port 1 and writes both values there. My first driver
took that mapping for the top CRM and v2 kept the mistake. The PCIe
series will write them to the port 1 ctrl window.
Best regards,
Navid