Re: [PATCH 1/3] mmc: sdhci-msm: Enable ICE before enabling crypto support

[Eric Biggers]

On Thu, Nov 12, 2026 at 05:00:56PM +0530, Kuldeep Singh wrote:
> On 24-10-2026 23:59, Eric Biggers wrote:
> > On Thu, Oct 22, 2026 at 03:21:50PM +0530, Kuldeep Singh wrote:
> >> Remove ICE enable call from CQE path, since ICE is now enabled
> >> during SDHCI crypto initialization only.
> 
> Sorry for delayed response as I was away on vacation for more than
> 2weeks and hence couldn't catchup on the thread!!
> 
> > 
> > This change makes the low-power and "optimization" settings in
> > QCOM_ICE_REG_ADVANCED_CONTROL be set only once, during probe.  Is that
> > correct?  Those settings never get lost at runtime?
> 
> Yes, the low-power and optimization settings are set once and are
> retained over suspend/resume cycle.

What about hibernation?  We recently went through this for keyslot
reprogramming, and it was established that keyslots need to be
reprogrammed after a hibernation image is restored.  See the commit
https://git.kernel.org/linus/8b190e9c0b36aac5
Doesn't the same apply to qcom_ice_enable()?  If so, this commit breaks
ICE upon restoring a hibernation image.

- Eric