Re: [PATCH v2 19/24] dt-bindings: spi: Add ZTE ZX family SPI flash controller binding
From: Navid Ghahremani
Date: Fri Nov 13 2026 - 00:51:57 EST
Hi Krzysztof,
Krzysztof Kozlowski wrote:
> Where are all other properties your driver is using? DMAs? Resets and
> whatnot?
You are right. The driver used an optional reset and the rx and tx DMA
channels, and the binding described none of them.
> Did you actually test your DTS against bindings?
Not properly. For v2 I only validated the binding files with
dt-doc-validate. I have now run make CHECK_DTBS=y on the v2 H3600 DTS.
It passes, but only because my SPI node also leaves out the DMA
channels and the reset, so the check could not show the gap. The
binding has to describe what the hardware and the driver use and not
only what my DTS uses.
I am dropping this binding and the SPI driver from my series since
Stefan will submit a driver. For the rest of the series I run make
dt_binding_check and make CHECK_DTBS=y on the board DTS before sending,
and I compare each binding with the properties its driver reads.
>From your other mail on this patch, none of the subjects in the next
version will have the redundant word binding.
Best regards,
Navid