Re: [PATCH v2] accel/rocket: Fix drm_mm UAF on close vs in-flight job

From: Gyeyoung Baek

Date: Fri Nov 13 2026 - 01:11:20 EST


Gentle ping.

This is hit frequently in testing whenever a process exits
with jobs still in flight.

On Sun, Nov 1, 2026 at 4:37 PM Gyeyoung Baek <gye976@xxxxxxxxx> wrote:
>
> The drm_mm and its mutex live in rocket_file_priv, which
> rocket_postclose() frees on fd close. But a BO held by an
> in-flight job is only freed after close, from the drm_sched
> free_job worker, and its destructor then accesses the already
> freed drm_mm and mutex.
>
> BUG: KASAN: slab-use-after-free in __mutex_trylock_common+0x90/0x1e8
> Workqueue: <NPU>.npu drm_sched_free_job_work [gpu_sched]
> Call trace:
> __mutex_lock
> rocket_gem_bo_free
> rocket_job_cleanup
> rocket_job_free
> drm_sched_free_job_work [gpu_sched]
>
> Move drm_mm and the mutex out of rocket_file_priv into the
> kref-managed rocket_iommu_domain (renamed to rocket_vm). Their
> lifetime now matches the vm's: as long as a BO or job references
> the vm, the address-space state stays alive.
>
> Fixes: ed98261b4168 ("accel/rocket: Add a new driver for Rockchip's NPU")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Gyeyoung Baek <gye976@xxxxxxxxx>
> ---
> Changes in v2:
> - Rebased on drm-misc-fixes and resent. No functional changes.
> - Link to v1: https://lore.kernel.org/r/20260426103758.1373137-1-gye976@xxxxxxxxx
>
> drivers/accel/rocket/rocket_drv.c | 74 +++++++++++++++----------------
> drivers/accel/rocket/rocket_drv.h | 13 +++---
> drivers/accel/rocket/rocket_gem.c | 31 ++++++-------
> drivers/accel/rocket/rocket_gem.h | 4 +-
> drivers/accel/rocket/rocket_job.c | 6 +--
> drivers/accel/rocket/rocket_job.h | 2 +-
> 6 files changed, 64 insertions(+), 66 deletions(-)
>
> diff --git a/drivers/accel/rocket/rocket_drv.c b/drivers/accel/rocket/rocket_drv.c
> index 5d7805c41dc..f58c15131dc 100644
> --- a/drivers/accel/rocket/rocket_drv.c
> +++ b/drivers/accel/rocket/rocket_drv.c
> @@ -26,46 +26,54 @@ static struct platform_device *drm_dev;
> static struct rocket_device *rdev;
>
> static void
> -rocket_iommu_domain_destroy(struct kref *kref)
> +rocket_vm_destroy(struct kref *kref)
> {
> - struct rocket_iommu_domain *domain = container_of(kref, struct rocket_iommu_domain, kref);
> + struct rocket_vm *vm = container_of(kref, struct rocket_vm, kref);
>
> - iommu_domain_free(domain->domain);
> - domain->domain = NULL;
> - kfree(domain);
> + drm_mm_takedown(&vm->mm);
> + mutex_destroy(&vm->lock);
> + iommu_domain_free(vm->domain);
> + vm->domain = NULL;
> + kfree(vm);
> }
>
> -static struct rocket_iommu_domain*
> -rocket_iommu_domain_create(struct device *dev)
> +static struct rocket_vm *
> +rocket_vm_create(struct device *dev)
> {
> - struct rocket_iommu_domain *domain = kmalloc_obj(*domain);
> + struct rocket_vm *vm = kmalloc_obj(*vm);
> + u64 start, end;
> void *err;
>
> - if (!domain)
> + if (!vm)
> return ERR_PTR(-ENOMEM);
>
> - domain->domain = iommu_paging_domain_alloc(dev);
> - if (IS_ERR(domain->domain)) {
> - err = ERR_CAST(domain->domain);
> - kfree(domain);
> + vm->domain = iommu_paging_domain_alloc(dev);
> + if (IS_ERR(vm->domain)) {
> + err = ERR_CAST(vm->domain);
> + kfree(vm);
> return err;
> }
> - kref_init(&domain->kref);
>
> - return domain;
> + start = vm->domain->geometry.aperture_start;
> + end = vm->domain->geometry.aperture_end;
> + drm_mm_init(&vm->mm, start, end - start + 1);
> + mutex_init(&vm->lock);
> + kref_init(&vm->kref);
> +
> + return vm;
> }
>
> -struct rocket_iommu_domain *
> -rocket_iommu_domain_get(struct rocket_file_priv *rocket_priv)
> +struct rocket_vm *
> +rocket_vm_get(struct rocket_file_priv *rocket_priv)
> {
> - kref_get(&rocket_priv->domain->kref);
> - return rocket_priv->domain;
> + kref_get(&rocket_priv->vm->kref);
> + return rocket_priv->vm;
> }
>
> void
> -rocket_iommu_domain_put(struct rocket_iommu_domain *domain)
> +rocket_vm_put(struct rocket_vm *vm)
> {
> - kref_put(&domain->kref, rocket_iommu_domain_destroy);
> + kref_put(&vm->kref, rocket_vm_destroy);
> }
>
> static int
> @@ -73,7 +81,6 @@ rocket_open(struct drm_device *dev, struct drm_file *file)
> {
> struct rocket_device *rdev = to_rocket_device(dev);
> struct rocket_file_priv *rocket_priv;
> - u64 start, end;
> int ret;
>
> if (!try_module_get(THIS_MODULE))
> @@ -86,29 +93,22 @@ rocket_open(struct drm_device *dev, struct drm_file *file)
> }
>
> rocket_priv->rdev = rdev;
> - rocket_priv->domain = rocket_iommu_domain_create(rdev->cores[0].dev);
> - if (IS_ERR(rocket_priv->domain)) {
> - ret = PTR_ERR(rocket_priv->domain);
> + rocket_priv->vm = rocket_vm_create(rdev->cores[0].dev);
> + if (IS_ERR(rocket_priv->vm)) {
> + ret = PTR_ERR(rocket_priv->vm);
> goto err_free;
> }
>
> file->driver_priv = rocket_priv;
>
> - start = rocket_priv->domain->domain->geometry.aperture_start;
> - end = rocket_priv->domain->domain->geometry.aperture_end;
> - drm_mm_init(&rocket_priv->mm, start, end - start + 1);
> - mutex_init(&rocket_priv->mm_lock);
> -
> ret = rocket_job_open(rocket_priv);
> if (ret)
> - goto err_mm_takedown;
> + goto err_vm_put;
>
> return 0;
>
> -err_mm_takedown:
> - mutex_destroy(&rocket_priv->mm_lock);
> - drm_mm_takedown(&rocket_priv->mm);
> - rocket_iommu_domain_put(rocket_priv->domain);
> +err_vm_put:
> + rocket_vm_put(rocket_priv->vm);
> err_free:
> kfree(rocket_priv);
> err_put_mod:
> @@ -122,9 +122,7 @@ rocket_postclose(struct drm_device *dev, struct drm_file *file)
> struct rocket_file_priv *rocket_priv = file->driver_priv;
>
> rocket_job_close(rocket_priv);
> - mutex_destroy(&rocket_priv->mm_lock);
> - drm_mm_takedown(&rocket_priv->mm);
> - rocket_iommu_domain_put(rocket_priv->domain);
> + rocket_vm_put(rocket_priv->vm);
> kfree(rocket_priv);
> module_put(THIS_MODULE);
> }
> diff --git a/drivers/accel/rocket/rocket_drv.h b/drivers/accel/rocket/rocket_drv.h
> index 2c673bb99cc..2754f46f174 100644
> --- a/drivers/accel/rocket/rocket_drv.h
> +++ b/drivers/accel/rocket/rocket_drv.h
> @@ -11,22 +11,23 @@
>
> extern const struct dev_pm_ops rocket_pm_ops;
>
> -struct rocket_iommu_domain {
> +struct rocket_vm {
> struct iommu_domain *domain;
> + struct drm_mm mm;
> + /* protects @mm */
> + struct mutex lock;
> struct kref kref;
> };
>
> struct rocket_file_priv {
> struct rocket_device *rdev;
>
> - struct rocket_iommu_domain *domain;
> - struct drm_mm mm;
> - struct mutex mm_lock;
> + struct rocket_vm *vm;
>
> struct drm_sched_entity sched_entity;
> };
>
> -struct rocket_iommu_domain *rocket_iommu_domain_get(struct rocket_file_priv *rocket_priv);
> -void rocket_iommu_domain_put(struct rocket_iommu_domain *domain);
> +struct rocket_vm *rocket_vm_get(struct rocket_file_priv *rocket_priv);
> +void rocket_vm_put(struct rocket_vm *vm);
>
> #endif
> diff --git a/drivers/accel/rocket/rocket_gem.c b/drivers/accel/rocket/rocket_gem.c
> index a5fffa51ff3..057fd82e2a5 100644
> --- a/drivers/accel/rocket/rocket_gem.c
> +++ b/drivers/accel/rocket/rocket_gem.c
> @@ -14,20 +14,20 @@
> static void rocket_gem_bo_free(struct drm_gem_object *obj)
> {
> struct rocket_gem_object *bo = to_rocket_bo(obj);
> - struct rocket_file_priv *rocket_priv = bo->driver_priv;
> + struct rocket_vm *vm = bo->vm;
> size_t unmapped;
>
> drm_WARN_ON(obj->dev, refcount_read(&bo->base.pages_use_count) > 1);
>
> - unmapped = iommu_unmap(bo->domain->domain, bo->mm.start, bo->size);
> + unmapped = iommu_unmap(vm->domain, bo->mm.start, bo->size);
> drm_WARN_ON(obj->dev, unmapped != bo->size);
>
> - mutex_lock(&rocket_priv->mm_lock);
> + mutex_lock(&vm->lock);
> drm_mm_remove_node(&bo->mm);
> - mutex_unlock(&rocket_priv->mm_lock);
> + mutex_unlock(&vm->lock);
>
> - rocket_iommu_domain_put(bo->domain);
> - bo->domain = NULL;
> + rocket_vm_put(vm);
> + bo->vm = NULL;
>
> drm_gem_shmem_free(&bo->base);
> }
> @@ -64,6 +64,7 @@ int rocket_ioctl_create_bo(struct drm_device *dev, void *data, struct drm_file *
> struct drm_gem_shmem_object *shmem_obj;
> struct rocket_gem_object *rkt_obj;
> struct drm_gem_object *gem_obj;
> + struct rocket_vm *vm;
> struct sg_table *sgt;
> int ret;
>
> @@ -74,8 +75,8 @@ int rocket_ioctl_create_bo(struct drm_device *dev, void *data, struct drm_file *
> gem_obj = &shmem_obj->base;
> rkt_obj = to_rocket_bo(gem_obj);
>
> - rkt_obj->driver_priv = rocket_priv;
> - rkt_obj->domain = rocket_iommu_domain_get(rocket_priv);
> + vm = rocket_vm_get(rocket_priv);
> + rkt_obj->vm = vm;
> rkt_obj->size = args->size;
> rkt_obj->offset = 0;
>
> @@ -85,15 +86,15 @@ int rocket_ioctl_create_bo(struct drm_device *dev, void *data, struct drm_file *
> goto err;
> }
>
> - mutex_lock(&rocket_priv->mm_lock);
> - ret = drm_mm_insert_node_generic(&rocket_priv->mm, &rkt_obj->mm,
> + mutex_lock(&vm->lock);
> + ret = drm_mm_insert_node_generic(&vm->mm, &rkt_obj->mm,
> rkt_obj->size, PAGE_SIZE,
> 0, 0);
> - mutex_unlock(&rocket_priv->mm_lock);
> + mutex_unlock(&vm->lock);
> if (ret)
> goto err;
>
> - ret = iommu_map_sgtable(rocket_priv->domain->domain,
> + ret = iommu_map_sgtable(vm->domain,
> rkt_obj->mm.start,
> shmem_obj->sgt,
> IOMMU_READ | IOMMU_WRITE);
> @@ -118,13 +119,13 @@ int rocket_ioctl_create_bo(struct drm_device *dev, void *data, struct drm_file *
> return 0;
>
> err_unmap:
> - iommu_unmap(rocket_priv->domain->domain,
> + iommu_unmap(vm->domain,
> rkt_obj->mm.start, rkt_obj->size);
>
> err_remove_node:
> - mutex_lock(&rocket_priv->mm_lock);
> + mutex_lock(&vm->lock);
> drm_mm_remove_node(&rkt_obj->mm);
> - mutex_unlock(&rocket_priv->mm_lock);
> + mutex_unlock(&vm->lock);
>
> err:
> drm_gem_shmem_object_free(gem_obj);
> diff --git a/drivers/accel/rocket/rocket_gem.h b/drivers/accel/rocket/rocket_gem.h
> index 24043033450..e1fbbd8cf71 100644
> --- a/drivers/accel/rocket/rocket_gem.h
> +++ b/drivers/accel/rocket/rocket_gem.h
> @@ -9,9 +9,7 @@
> struct rocket_gem_object {
> struct drm_gem_shmem_object base;
>
> - struct rocket_file_priv *driver_priv;
> -
> - struct rocket_iommu_domain *domain;
> + struct rocket_vm *vm;
> struct drm_mm_node mm;
> size_t size;
> u32 offset;
> diff --git a/drivers/accel/rocket/rocket_job.c b/drivers/accel/rocket/rocket_job.c
> index 4bc4f9c8ee4..0de56bb84e3 100644
> --- a/drivers/accel/rocket/rocket_job.c
> +++ b/drivers/accel/rocket/rocket_job.c
> @@ -240,7 +240,7 @@ static void rocket_job_cleanup(struct kref *ref)
> refcount);
> unsigned int i;
>
> - rocket_iommu_domain_put(job->domain);
> + rocket_vm_put(job->vm);
>
> dma_fence_put(job->done_fence);
> dma_fence_put(job->inference_done_fence);
> @@ -321,7 +321,7 @@ static struct dma_fence *rocket_job_run(struct drm_sched_job *sched_job)
> if (ret < 0)
> goto err_put_fences;
>
> - ret = iommu_attach_group(job->domain->domain, core->iommu_group);
> + ret = iommu_attach_group(job->vm->domain, core->iommu_group);
> if (ret < 0)
> goto err_put_pm;
>
> @@ -564,7 +564,7 @@ static int rocket_ioctl_submit_job(struct drm_device *dev, struct drm_file *file
> kref_init(&rjob->refcount);
>
> rjob->rdev = rdev;
> - rjob->domain = rocket_iommu_domain_get(file_priv);
> + rjob->vm = rocket_vm_get(file_priv);
>
> ret = drm_sched_job_init(&rjob->base,
> &file_priv->sched_entity,
> diff --git a/drivers/accel/rocket/rocket_job.h b/drivers/accel/rocket/rocket_job.h
> index 4ae00feec3b..9373c3d0273 100644
> --- a/drivers/accel/rocket/rocket_job.h
> +++ b/drivers/accel/rocket/rocket_job.h
> @@ -36,7 +36,7 @@ struct rocket_job {
> /* Fence to be signaled by IRQ handler when the job is complete. */
> struct dma_fence *done_fence;
>
> - struct rocket_iommu_domain *domain;
> + struct rocket_vm *vm;
>
> struct kref refcount;
> };
>
> base-commit: f00d7a241f846b053e89c0bb2285ef5988d4cafc
> --
> 2.43.0
>


--
Thanks,
Gyeyoung