[PATCH v17 10/10] qcom-tgu: Add reset node to initialize

From: Songwei Chai

Date: Fri Nov 13 2026 - 01:27:38 EST


Add reset node to initialize the value of
priority/condition_decode/condition_select/timer/counter nodes.

Reviewed-by: Jie Gan <jie.gan@xxxxxxxxxxxxxxxx>
Signed-off-by: Songwei Chai <songwei.chai@xxxxxxxxxxxxxxxx>
---
.../ABI/testing/sysfs-bus-amba-devices-tgu | 7 ++
drivers/hwtracing/qcom/tgu.c | 85 +++++++++++++++++++
2 files changed, 92 insertions(+)

diff --git a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu
index e0ea5419188e..c0f10678e4df 100644
--- a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu
+++ b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu
@@ -51,3 +51,10 @@ KernelVersion: 7.5
Contact: Jinlong Mao <jinlong.mao@xxxxxxxxxxxxxxxx>, Songwei Chai <songwei.chai@xxxxxxxxxxxxxxxx>
Description:
(RW) Set/Get the counter value with specific step for TGU.
+
+What: /sys/bus/amba/devices/<tgu-name>/reset_tgu
+Date: November 2026
+KernelVersion: 7.5
+Contact: Jinlong Mao <jinlong.mao@xxxxxxxxxxxxxxxx>, Songwei Chai <songwei.chai@xxxxxxxxxxxxxxxx>
+Description:
+ (Write) Write 1 to reset the dataset for TGU.
diff --git a/drivers/hwtracing/qcom/tgu.c b/drivers/hwtracing/qcom/tgu.c
index 1cb131a3c521..2386c71ab8d1 100644
--- a/drivers/hwtracing/qcom/tgu.c
+++ b/drivers/hwtracing/qcom/tgu.c
@@ -251,6 +251,18 @@ static ssize_t tgu_write_all_hw_regs(struct tgu_drvdata *drvdata)
int i, j, k, index = 0;

CS_UNLOCK(drvdata->base);
+
+ /*
+ * Quiesce the detection engine before mutating any comparison input.
+ * This function is also reached from reset_tgu_store() while the TGU is
+ * already running (TGU_CONTROL == 1); rewriting the priority/condition/
+ * timer/counter registers register-by-register on a live engine could
+ * feed a transient, half-updated match into CTI/interrupt consumers.
+ * Programming with CONTROL == 0 and only re-enabling at the end keeps the
+ * program-then-enable ordering for every caller.
+ */
+ writel(0, drvdata->base + TGU_CONTROL);
+
for (i = 0; i < drvdata->num_step; i++) {
for (j = 0; j < MAX_PRIORITY; j++) {
for (k = 0; k < drvdata->num_reg; k++) {
@@ -470,8 +482,81 @@ static ssize_t enable_tgu_store(struct device *dev,
}
static DEVICE_ATTR_RW(enable_tgu);

+/*
+ * Element counts for drvdata's shadow tables, shared so the reset path
+ * below can't drift from how each array is actually sized/indexed.
+ */
+#define TGU_PRIORITY_COUNT(drvdata) \
+ (MAX_PRIORITY * (drvdata)->num_step * (drvdata)->num_reg)
+#define TGU_CONDITION_DECODE_COUNT(drvdata) \
+ ((drvdata)->num_step * (drvdata)->num_condition_decode)
+#define TGU_CONDITION_SELECT_COUNT(drvdata) \
+ ((drvdata)->num_step * (drvdata)->num_condition_select)
+#define TGU_TIMER_COUNT(drvdata) \
+ ((drvdata)->num_step * (drvdata)->num_timer)
+#define TGU_COUNTER_COUNT(drvdata) \
+ ((drvdata)->num_step * (drvdata)->num_counter)
+
+static ssize_t reset_tgu_store(struct device *dev,
+ struct device_attribute *attr, const char *buf,
+ size_t size)
+{
+ struct tgu_drvdata *drvdata = dev_get_drvdata(dev);
+ unsigned long value;
+ int i, ret;
+
+ if (kstrtoul(buf, 0, &value) || value != 1)
+ return -EINVAL;
+
+ /*
+ * Hold the mutex across the whole sequence so it cannot race with
+ * enable_tgu_store()/tgu_dataset_store(): the enabled check and the
+ * hardware access stay consistent. No PM reference is taken or dropped
+ * here - the shadow tables are plain memory, and the hardware is only
+ * touched when the device is already resumed via the enable reference.
+ */
+ guard(mutex)(&drvdata->lock);
+
+ memset(drvdata->priority, 0,
+ TGU_PRIORITY_COUNT(drvdata) * sizeof(*drvdata->priority));
+
+ /*
+ * Every decode register is about to be overwritten with the neutral
+ * 'NOT' value below, so there is nothing for a prior memset to zero;
+ * calculate_array_location()'s step/reg indices for TGU_CONDITION_DECODE
+ * densely cover the whole 0..TGU_CONDITION_DECODE_COUNT(drvdata)-1 range
+ * with no gaps, so a flat loop over that range reaches every decode
+ * register.
+ */
+ for (i = 0; i < TGU_CONDITION_DECODE_COUNT(drvdata); i++)
+ drvdata->condition_decode[i] = TGU_CONDITION_DECODE_NOT;
+
+ memset(drvdata->condition_select, 0,
+ TGU_CONDITION_SELECT_COUNT(drvdata) *
+ sizeof(*drvdata->condition_select));
+
+ memset(drvdata->timer, 0,
+ TGU_TIMER_COUNT(drvdata) * sizeof(*drvdata->timer));
+
+ memset(drvdata->counter, 0,
+ TGU_COUNTER_COUNT(drvdata) * sizeof(*drvdata->counter));
+
+ /* If the TGU is running, apply the cleared configuration immediately. */
+ if (drvdata->enabled) {
+ ret = tgu_write_all_hw_regs(drvdata);
+ if (ret)
+ return ret;
+ }
+
+ dev_dbg(dev, "Qualcomm-TGU reset complete\n");
+
+ return size;
+}
+static DEVICE_ATTR_WO(reset_tgu);
+
static struct attribute *tgu_common_attrs[] = {
&dev_attr_enable_tgu.attr,
+ &dev_attr_reset_tgu.attr,
NULL,
};

--
2.34.1