Re: [PATCH v1 2/2] Input: keyboard: Add Nuvoton MA35D1 keypad driver

From: Uwe Kleine-König

Date: Fri Nov 13 2026 - 03:01:43 EST


On Tue, Nov 10, 2026 at 07:14:19PM +0800, Feng-Yi Hsueh wrote:
> +#include <linux/mod_devicetable.h>
> [...]
> +#include <linux/platform_device.h>

Please don't include <linux/mod_devicetable.h> as it introduces a bunch
of unneeded build dependencies. <linux/platform_device.h> is sufficient
to get of_device_id.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature