Re: [PATCH v2 1/5] dt-bindings: clock: Add STM32MP25 SYSCFG clock controller
From: Krzysztof Kozlowski
Date: Fri Nov 13 2026 - 04:04:00 EST
On Tue, Nov 10, 2026 at 02:10:21PM +0100, Gabriel Fernandez wrote:
> The SYSCFG of the STM32MP23x and STM32MP25x SoCs selects the LTDC pixel
> clock among the LTDC kernel clock, the LVDS PHY pixel clock and the DSI
> PHY byte lane clock.
>
> Add the binding for this clock controller, described as a
> clock-controller sub-node of the SYSCFG node, along with the header
> defining the identifiers of the provided clocks.
>
> A sub-node is needed since the inputs of the mux can't be described by
> the "clocks" property of the SYSCFG node: the SYSCFG is a syscon, whose
> first clock is taken as the clock of its registers and enabled around
> each register access.
>
> The inputs are listed in the "ltdc", "lvds", "dsi" order so that the
> ones missing on a SoC (no LVDS nor DSI on STM32MP231/233 and
> STM32MP251/253) can be omitted at the end of the list. "#clock-cells"
> is 1 so that the other clocks of the SYSCFG can be added later without
> changing the binding.
>
> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxxx>
> ---
> .../bindings/clock/st,stm32mp25-syscfg-clk.yaml | 61 ++++++++++++++++++++++
> .../dt-bindings/clock/st,stm32mp25-syscfg-clk.h | 12 +++++
> 2 files changed, 73 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/st,stm32mp25-syscfg-clk.yaml b/Documentation/devicetree/bindings/clock/st,stm32mp25-syscfg-clk.yaml
> new file mode 100644
> index 000000000000..027d14f28b0c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/st,stm32mp25-syscfg-clk.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/st,stm32mp25-syscfg-clk.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: STMicroelectronics STM32MP2 SYSCFG clock controller
> +
> +maintainers:
> + - Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxxx>
> +
> +description: |
> + The SYSCFG of the STM32MP23x and STM32MP25x SoCs provides clocks, described
> + by a clock controller sub-node of the SYSCFG node.
> +
> + The provided clocks are identified by the macros defined in
> + include/dt-bindings/clock/st,stm32mp25-syscfg-clk.h:
> + - CK_SYSCFG_PIX_LTDC: LTDC pixel clock, selected in the DISPLAYCLKCR
> + register among the LTDC kernel clock, used by the RGB parallel output,
> + the LVDS PHY pixel clock and the DSI PHY byte lane clock.
> +
> +properties:
> + compatible:
> + const: st,stm32mp25-syscfg-clk
> +
> + "#clock-cells":
> + const: 1
So you have 1 clock, thus drop the header and here you have cells=0.
> +
> + clocks:
> + minItems: 1
Why is this flexible? Device either has or has not these inputs.
> + items:
> + - description: LTDC kernel clock
> + - description: LVDS PHY pixel clock
> + - description: DSI PHY byte lane clock
> +
> + clock-names:
> + minItems: 1
> + items:
> + - const: ltdc
> + - const: lvds
> + - const: dsi
> +
> +required:
> + - compatible
> + - "#clock-cells"
> + - clocks
> + - clock-names
Best regards,
Krzysztof