Re: [RFC PATCH v2 1/2] regmap: add regmap_reg_field_* APIs

From: Victor Chernyakin

Date: Fri Nov 13 2026 - 04:29:12 EST


> > -#define REG_FIELD(_reg, _lsb, _msb) { \
> > - .reg = _reg, \
> > - .lsb = _lsb, \
> > - .msb = _msb, \
> > - }
> > +#define REG_FIELD(_reg, _lsb, _msb) ((struct reg_field){ \
> > + .reg = _reg, \
> > + .lsb = _lsb, \
> > + .msb = _msb, \
> > + })
> >
> > -#define REG_FIELD_ID(_reg, _lsb, _msb, _size, _offset) { \
> > - .reg = _reg, \
> > - .lsb = _lsb, \
> > - .msb = _msb, \
> > - .id_size = _size, \
> > - .id_offset = _offset, \
> > - }
> > +#define REG_FIELD_ID(_reg, _lsb, _msb, _size, _offset) ((struct reg_field){ \
> > + .reg = _reg, \
> > + .lsb = _lsb, \
> > + .msb = _msb, \
> > + .id_size = _size, \
> > + .id_offset = _offset, \
> > + })
>
> So, you convert them to compound literals. This change may be good on
> its own (see other similar changes in the kernel).
> The only problem you have is the outer parentheses. They should be
> dropped. If you need them, it's a problem on the user's side of this
> macros.

In this comment:

https://lore.kernel.org/all/auzCxxkUB9p6WKNC@ashevche-desk.local/

...I got the impresssion that you were *against* dealing with it
on the user's side (in REG_FIELD_GENMASK), and I agreed: if it
can be handled in REG_FIELD, why make users worry about it?
But now it seems you're saying the opposite. Can you clarify
your stance?