Re: [PATCH RFC 12/13] drm/powervr_sgx: Add the DRM driver, power management and debugging
From: Joseph Telaak
Date: Fri Nov 13 2026 - 04:33:26 EST
On Fri, Nov 13, 2026 at 07:23:36AM +0100, Uwe Kleine-König wrote:
> On Thu, Nov 12, 2026 at 05:59:02PM -0500, Joseph Telaak wrote:
> > +static const struct pci_device_id pvrsgx_pci_ids[] = {
> > + { PCI_VDEVICE(INTEL, 0x089b), 545 }, /* CE5300 family: SGX545 */
>
> Please make this
>
> { PCI_VDEVICE(INTEL, 0x089b), .driver_data = 545 }, /* CE5300 family: SGX545 */
Will do in v2.
> Don't include <linux/mod_devicetable.h>. of_device_id is already
> provided by <linux/of.h> and also by <linux/platform_device.h> without
> the useless dependencies that <linux/mod_devicetable.h> introduces.
Thanks, I'll drop it in v2, and check the other files for the same.
Joseph