Re: [PATCH] soc: qcom: llcc-qcom Fix SM8750 settings

[Luca Weiss]

Hi Konrad,

Missing ":" after llcc-qcom in the subject?

Regards
Luca

On Fri Nov 13, 2026 at 10:01 AM CET, Konrad Dybcio wrote:
> Bring the settings in line with the with the recommendations (and also
> with the downstream kernel).
>
> Reported-by: yzddMr6 <yzddmr6@xxxxxxxxx>
> Closes: https://lore.kernel.org/linux-arm-msm/20261111-sm8750-llcc-island1-v1-1-64055702ca3f@xxxxxxxxx/
> Fixes: 2c04e58e30ce ("soc: qcom: llcc-qcom: Add support for SM8750")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> ---
>  drivers/soc/qcom/llcc-qcom.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
> index d7a42a8040a16388a79c24e4d1f1e88de9c87ec0..df213548637351fdaeeb81b860f0ee2631f2062a 100644
> --- a/drivers/soc/qcom/llcc-qcom.c
> +++ b/drivers/soc/qcom/llcc-qcom.c
> @@ -3869,7 +3869,8 @@ static const struct llcc_slice_config sm8750_data[] = {
>  		.priority = 5,
>  		.fixed_size = true,
>  		.bonus_ways = 0xffffffff,
> -		.vict_prio = true,
> +		.ovcap_en = true,
> +		.parent_slice_id = 33,
>  	}, {
>  		.usecase_id = LLCC_MODPE,
>  		.slice_id = 29,
> @@ -3923,7 +3924,7 @@ static const struct llcc_slice_config sm8750_data[] = {
>  		.max_cap = 7936,
>  		.priority = 7,
>  		.fixed_size = true,
> -		.bonus_ways = 0x7fffffff,
> +		.res_ways = 0x7fffffff,
>  	}, {
>  		.usecase_id = LLCC_DISP_WB,
>  		.slice_id = 23,
> @@ -3946,7 +3947,7 @@ static const struct llcc_slice_config sm8750_data[] = {
>  		.fixed_size = true,
>  		.bonus_ways = 0xffffffff,
>  		.cache_mode = 2,
> -		.ovcap_prio = true,
> +		.ovcap_en = true,
>  		.parent_slice_id = 33,
>  	}, {
>  		.usecase_id = LLCC_CAMOFE,
> @@ -3956,7 +3957,7 @@ static const struct llcc_slice_config sm8750_data[] = {
>  		.fixed_size = true,
>  		.bonus_ways = 0xffffffff,
>  		.stale_en = true,
> -		.ovcap_prio = true,
> +		.ovcap_en = true,
>  		.parent_slice_id = 33,
>  	}, {
>  		.usecase_id = LLCC_CAMRTIP,
> @@ -3966,7 +3967,7 @@ static const struct llcc_slice_config sm8750_data[] = {
>  		.fixed_size = true,
>  		.bonus_ways = 0xffffffff,
>  		.stale_en = true,
> -		.ovcap_prio = true,
> +		.ovcap_en = true,
>  		.parent_slice_id = 33,
>  	}, {
>  		.usecase_id = LLCC_CAMSRTIP,
> @@ -3976,17 +3977,17 @@ static const struct llcc_slice_config sm8750_data[] = {
>  		.fixed_size = true,
>  		.bonus_ways = 0xffffffff,
>  		.stale_en = true,
> -		.ovcap_prio = true,
> +		.ovcap_en = true,
>  		.parent_slice_id = 33,
>  	}, {
>  		.usecase_id = LLCC_CAMRTRF,
>  		.slice_id = 7,
>  		.max_cap = 3584,
> -		.priority = 1,
> +		.priority = 3,
>  		.fixed_size = true,
>  		.bonus_ways = 0xffffffff,
>  		.stale_en = true,
> -		.ovcap_prio = true,
> +		.ovcap_en = true,
>  		.parent_slice_id = 33,
>  	}, {
>  		.usecase_id = LLCC_CAMSRTRF,
> @@ -3996,7 +3997,7 @@ static const struct llcc_slice_config sm8750_data[] = {
>  		.fixed_size = true,
>  		.bonus_ways = 0xffffffff,
>  		.stale_en = true,
> -		.ovcap_prio = true,
> +		.ovcap_en = true,
>  		.parent_slice_id = 33,
>  	}, {
>  		.usecase_id = LLCC_CPUSSMPAM,
>
> ---
> base-commit: 8b7179210b22f8e48a82c5ceacb9d56a9c4cfec4
> change-id: 20261113-topic-8750_llcc-bd228d96b455
>
> Best regards,