Re: [PATCH 2/2] iio: gts-helper: fix duplicate NOTE section in struct iio_itime_sel_mul

[Matti Vaittinen]

On 13/11/2026 07:25, Oscar Alejandro Sánchez Lucero wrote:
> Replace the repeated 'NOTE:' prefixes in struct iio_itime_sel_mul
> kernel-doc comments with plain sentences to avoid the duplicate section
> name warning.
>
> Verified with ./scripts/kernel-doc, checkpatch.pl --strict, and a W=1
> build of drivers/iio/industrialio-gts-helper.o.
>
> Signed-off-by: Oscar Alejandro Sánchez Lucero <aleszlucero@xxxxxxxxx>
> ---
>   include/linux/iio/iio-gts-helper.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/iio/iio-gts-helper.h b/include/linux/iio/iio-gts-helper.h
> index 0c4b2e9fbe1e..3f07a46ddff2 100644
> --- a/include/linux/iio/iio-gts-helper.h
> +++ b/include/linux/iio/iio-gts-helper.h
> @@ -47,9 +47,9 @@ struct iio_gain_sel_pair {
>    * @time_us:	Integration time in microseconds. Time values must be positive,
>    *		negative values are reserved for error handling.
>    * @sel:	Selector (usually register value) used to indicate this time
> - *		NOTE: Only selectors >= 0 supported.
> + *		Note that only selectors >= 0 are supported.
>    * @mul:	Multiplication to the values caused by this time.
> - *		NOTE: Only multipliers > 0 supported.
> + *		Note that only multipliers > 0 are supported.
>    */
>   struct iio_itime_sel_mul {
>   	int time_us;

I am unsure the "Note that..." serves any real value. Might as well be 
short and concise:
"NOTE: Only multipliers > 0 supported." => "Only multipliers > 0 supported."

Well, "Note that only multipliers > 0 are supported." isn't much longer 
so it works well enough for me unless you respin this for some other reason.

Thanks for the fix!

Yours,
	-- Matti

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~