Re: [PATCH net-next v2 1/2] dt-bindings: net: rockchip-dwmac: Add RK3572

[Cunhao Lu]

Hi,

> > Add the rockchip,rk3572-gmac compatible with the snps,dwmac-4.20a
> > fallback and require rockchip,php-grf.
> > 
> > Signed-off-by: Cunhao Lu <1579567540@xxxxxx>
> > ---
> > Changes in v2:
> > - Add RK3572 to the shared Synopsys compatible list for consistency.
>
> This doesn't address Andrew's request to deprecate the tx_delay and
> rx_delay properties for that new SoC. Even if the board you're using
> doesn't need them, we need to make sure new designs will use the
> generic properties for RGMII delays :)
> 
> The older rockchip glues have no choice but to keep accepting these for
> compat reasons.

Sorry for the misunderstanding. I had only removed tx_delay and
rx_delay from the device tree for the board I am using.

In v4, I will disallow both properties for rockchip,rk3572-gmac in
the DT binding and mark tx_delay and rx_delay as deprecated.

Best regards,
Cunhao Lu