Re: [PATCH] ALSA: aw2-alsa: select SND_PCM

[Takashi Iwai]

On Fri, 13 Nov 2026 07:46:14 +0100,
Jude Gyimah wrote:
> 
> Several stanzas in sound/pci/Kconfig select SND_PCM.
> SND_AW2 selects nothing at all.
> 
> aw2-alsa calls snd_pcm_new, which sound/core/pcm.c provides under SND_PCM.
> 
>   aw2-alsa.c:(.text+0x554): undefined reference to `snd_pcm_new'
> 
> 4 symbols are undefined in all.
> 
> The driver can be built into vmlinux while SND_PCM is a module, in which
> case the symbols are not there at link time.
> 
> Select rather than depend on: SND_PCM has no prompt of its own and is only
> ever enabled by a select, so a depends on would leave SND_AW2
> unselectable.
> 
> Reproduced on v7.3, arm64, with CONFIG_SND_AW2=y and CONFIG_SND_PCM=m.
> 
> Found with kreach, a static check that compares what Kconfig allows
> against the symbols the compiled objects actually reference.
> 
> Fixes: 98f2a97f207a ("[ALSA] Emagic Audiowerk 2 ALSA driver.")
> Signed-off-by: Jude Gyimah <jude.gyimah87@xxxxxxxxx>

Applied now.  It's interesting why this wasn't caught by build tests
for long time...


thanks,

Takashi