Re: [PATCH 1/5] dt-bindings: power: supply: add Qualcomm QGauge fuel gauge

[Krzysztof Kozlowski]

On Thu, Nov 12, 2026 at 02:07:27PM -0300, Val Packett wrote:
> From: Marc Lainez <marc.lainez@xxxxxxxxx>
> 
> Document the QGauge fuel-gauge block handled by the qcom_qg driver, with
> compatibles for the PMI632 and PM6150 PMICs.
> 
> Signed-off-by: Marc Lainez <marc.lainez@xxxxxxxxx>
> Signed-off-by: Val Packett <val@xxxxxxxxxxxx>
> ---
>  .../bindings/power/supply/qcom,qg.yaml        | 105 ++++++++++++++++++
>  MAINTAINERS                                   |   6 +
>  2 files changed, 111 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/supply/qcom,qg.yaml
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/qcom,qg.yaml b/Documentation/devicetree/bindings/power/supply/qcom,qg.yaml
> new file mode 100644
> index 000000000000..79dd18d87879
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/qcom,qg.yaml

Filename should match one of the compatibles.

> @@ -0,0 +1,105 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/supply/qcom,qg.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm QGauge Fuel Gauge
> +
> +maintainers:
> +  - Val Packett <val@xxxxxxxxxxxx>
> +
> +description:
> +  The QGauge (QG) block found in some Qualcomm PMICs (PM6150, PMI632)
> +  provides battery fuel gauging through hardware voltage and current
> +  FIFO sampling, open circuit voltage (OCV) measurement, and coulomb
> +  counting. The hardware has a multi-state FSM (S1-S7) that automatically
> +  transitions between active sampling and low-power sleep states.
> +
> +allOf:
> +  - $ref: /schemas/power/supply/power-supply.yaml#
> +  - $ref: /schemas/nvmem/nvmem-consumer.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,pm6150-qg
> +      - qcom,pmi632-qg
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    items:
> +      - description: Battery missing interrupt
> +      - description: Battery voltage low interrupt
> +      - description: Battery voltage empty interrupt
> +      - description: FIFO data update done interrupt
> +      - description: Good OCV measured interrupt
> +      - description: FSM state change interrupt
> +      - description: QG event interrupt
> +
> +  interrupt-names:
> +    items:
> +      - const: batt-missing
> +      - const: vbat-low
> +      - const: vbat-empty
> +      - const: fifo-done
> +      - const: good-ocv
> +      - const: fsm-state-chg
> +      - const: event
> +
> +  io-channels:
> +    items:
> +      - description: ADC channel for battery thermistor temperature
> +
> +  io-channel-names:
> +    items:
> +      - const: batt-therm
> +
> +  monitored-battery: true

drop

> +
> +  nvmem: true

Missing constraints


> +
> +  power-supplies: true

Drop

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-names
> +  - monitored-battery
> +
> +additionalProperties: false

unevaluatedProperties instead

> +
> +examples:

Best regards,
Krzysztof