Re: [PATCH v2 3/3] tools/bootconfig: Preserve values containing both types of quotes
From: Eduardo Mucelli
Date: Fri Nov 13 2026 - 06:55:05 EST
Hi Masami,
Thanks for the review.
The parser currently accepts the value, but the tool prints an output
that cannot be parsed again.
I agree that rejecting it would be preferable than supporting it
through the formatter.
I will drop this change. Would you prefer a patch that rejects mixed
quote values with a clear parsing error?
Thanks,
On Fri, Nov 13, 2026 at 6:21 AM Masami Hiramatsu (Google)
<mhiramat@xxxxxxxxxx> wrote:
>
> On Tue, 10 Nov 2026 20:08:47 +0100, Eduardo Mucelli Rezende Oliveira <edumucelli@xxxxxxxxx> wrote:
> > An unquoted bootconfig value can contain both single and double quote
> > characters, for example:
> >
> > message = He said "it's fine"
>
> Nack, I would not like to support this unclear value in bootconfig file.
> It is OK to *detect* this kind of mixing value as a wrong value, but to
> support this, we should support escaped quotes and force user to quote the
> string.
>
> message = 'He said "it\'s fine"'
>
> But is there any actual usage for supporting this syntax? I would like to
> keep the bootconfig as simple as possible.
>
> >
> > xbc_show_value() surrounds any value containing a double quote with
> > single quotes. If the value also contains a single quote, both compact
> > [...]
>
> Thanks,
>
> --
> Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
--
Eduardo Mucelli R. Oliveira -- http://eduar.do