Re: [PATCH v2 1/2] dt-bindings: media: qcom,glymur-camss: Drop port@3

From: Loic Poulain

Date: Fri Nov 13 2026 - 07:15:37 EST


On Fri, Nov 13, 2026 at 9:20 AM Nihal Kumar Gupta
<nihal.gupta@xxxxxxxxxxxxxxxx> wrote:
>
> Glymur has only three CSI2 PHYs, so there is no port@3 in the CAMSS
> binding.
>
> Limit the allowed ports to port@0 through port@2 and update the example
> to use port@2 for the third CSI2 PHY connection.

I know you put this in the cover letter but you should probably
explain here why you think it's ok to break the backward
compatibility.
Even if the binding is recent and we don't have in-tree users yet, you
may encounter pushback on this.

Regards,
Loic

>
> Signed-off-by: Nihal Kumar Gupta <nihal.gupta@xxxxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/media/qcom,glymur-camss.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,glymur-camss.yaml b/Documentation/devicetree/bindings/media/qcom,glymur-camss.yaml
> index a0b77edc212319fad69113f3d55ca24f184d4b23..18a38fc4f9025f6b927780f55ed4fab194091c02 100644
> --- a/Documentation/devicetree/bindings/media/qcom,glymur-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,glymur-camss.yaml
> @@ -109,7 +109,7 @@ properties:
> CSI input ports.
>
> patternProperties:
> - "^port@[0-3]$":
> + "^port@[0-2]$":
> $ref: /schemas/graph.yaml#/$defs/port-base
> unevaluatedProperties: false
>
> @@ -288,8 +288,8 @@ examples:
> };
> };
>
> - port@3 {
> - reg = <3>;
> + port@2 {
> + reg = <2>;
> camss_csiphy4_ep: endpoint {
> data-lanes = <1 2 3 4>;
> remote-endpoint = <&csiphy4_out>;
>
> --
> 2.34.1
>