Re: [PATCH RFC 35/41] zloop: refuse zone files on pseudo filesystems

From: Alexander Mikhalitsyn

Date: Fri Nov 13 2026 - 07:38:36 EST


On Tue, 2026-11-10 at 10:14 +0100, Christian Brauner wrote:
> zloop opens its zone files by name below the base directory but a
> bind
> mount can put any file there, including a procfs or sysfs file.
> Refuse
> files on pseudo filesystems as zone files just like loop does.
>
> Signed-off-by: Christian Brauner (Amutable) <brauner@xxxxxxxxxx>

Reviewed-by: Alexander Mikhalitsyn <alex@xxxxxxxxxxxx>

> ---
>  drivers/block/zloop.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/block/zloop.c b/drivers/block/zloop.c
> index 65634a39b0bf..dcc06dd47b04 100644
> --- a/drivers/block/zloop.c
> +++ b/drivers/block/zloop.c
> @@ -1137,6 +1137,11 @@ static int zloop_init_zone(struct zloop_device
> *zlo, struct zloop_options *opts,
>   goto out_fput;
>   }
>  
> + if (file_is_pseudo(zone->file)) {
> + ret = -EINVAL;
> + goto out_fput;
> + }
> +
>   if (zlo->block_size) {
>   ret = zloop_get_block_size(zlo, zone);
>   if (ret)