Re: [PATCH 16/17] arm64: dts: qcom: Add initial Halliday dtsi

From: Konrad Dybcio

Date: Fri Nov 13 2026 - 07:43:10 EST


On 11/9/26 1:33 AM, Stanislav Aleksandrov wrote:
> Add the device tree for the Qualcomm Halliday SoC
> (SXR2250P / Snapdragon XR2+ Gen 2).
>
> It describes the CPUs with their idle states, cpufreq and OPP tables,
> the GIC and the PDC, the timers, SCM, SMEM, RPMh with its clocks, power
> domains and interconnects, TLMM, GCC, SPMI, the apps SMMU, USB, UFS
> with ICE, TSENS with the thermal zones and the PMU.
>
> Signed-off-by: Stanislav Aleksandrov <lightofmysoul@xxxxxxxxx>
> ---

[...]

> + idle-states {
> + entry-method = "psci";
> +
> + gold_cpu_sleep_0: cpu-sleep-0-0 {
> + compatible = "arm,idle-state";
> + idle-state-name = "gold-power-collapse";
> + entry-latency-us = <400>;
> + exit-latency-us = <1400>;
> + min-residency-us = <2207>;
> + local-timer-stop;
> + arm,psci-suspend-param = <0x40000003>;

Please add the other idle states (D4 and E3) from the downstream
devicetree and match the order of properties (psci-suspend param)
to glymur.dtsi

[...]


> + usb_1: usb@a600000 {
> + compatible = "qcom,halliday-dwc3", "qcom,snps-dwc3";
> + reg = <0 0x0a600000 0 0xfc100>;

Please use '0x0' for zeroes in reg values

[...]


> + spmi_bus: spmi@c400000 {
> + compatible = "qcom,spmi-pmic-arb";
> + reg = <0 0x0c400000 0 0x3000>,
> + <0 0x0c500000 0 0x400000>,
> + <0 0x0c440000 0 0x80000>,
> + <0 0x0c4c0000 0 0x20000>,
> + <0 0x0c42d000 0 0x4000>;
> + reg-names = "core", "chnls", "obsrvr", "intr", "cnfg";

Let's break up such long lists into one-a-line

Otherwise lgtm, very nice!

Konrad