Re: [PATCH net-next v2 00/10] net: dsa: realtek: rtl8365mb: DCB ingress QoS offload

From: Alvin Šipraga

Date: Fri Nov 13 2026 - 08:08:23 EST


On Thu, Nov 12, 2026 at 09:37:43AM +0100, Oleksij Rempel wrote:
> Add ingress QoS offload for the RTL8365MB switch through the dcbnl app
> interface: a per-port default priority, PCP trust and DSCP trust. The
> mapping helpers go to net/core/ieee8021q_helpers.c so other drivers
> can share them.
>
> Two changes are visible to users. The driver now rejects a devicetree
> port that the chip does not have. With a default priority set, an
> untagged frame that leaves a VLAN-tagged port carries that priority as
> its PCP.
>
> Tested on an RTL8365MB-VC with eight queues.
>
> ETS scheduling and CPU-tag pre-classification will follow in separate
> series.
>
> v1:
> https://lore.kernel.org/r/20261002115850.962676-1-o.rempel@xxxxxxxxxxxxxx
>
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>

Notwithstanding my other comment, the whole thing looks good! So for the
series:

Reviewed-by: Alvin Šipraga <alvin.sipraga@xxxxxxxxxx>

> ---
> Oleksij Rempel (10):
> net: ieee8021q: print traffic type and queue count with %u
> net: ieee8021q: add pcp_to_tt()
> net: ieee8021q: clarify the tt_to_tc() traffic-class mapping
> net: ieee8021q: add tt_to_pcp()
> net: dsa: realtek: rtl8365mb: describe the ports of each chip
> net: dsa: realtek: rtl8365mb: store the egress queue count per chip
> net: dsa: realtek: rtl8365mb: add QoS baseline and DCB default prio
> net: dsa: realtek: rtl8365mb: program the PCP of untagged frames
> net: dsa: realtek: rtl8365mb: offload DCB apptrust
> net: dsa: realtek: rtl8365mb: report the DCB DSCP-to-priority map
>
> drivers/net/dsa/realtek/Kconfig | 1 +
> drivers/net/dsa/realtek/Makefile | 5 +-
> drivers/net/dsa/realtek/realtek.h | 32 ++
> drivers/net/dsa/realtek/rtl8365mb_main.c | 70 ++++-
> drivers/net/dsa/realtek/rtl8365mb_qos.c | 507 +++++++++++++++++++++++++++++++
> drivers/net/dsa/realtek/rtl8365mb_qos.h | 33 ++
> drivers/net/dsa/realtek/rtl83xx-qos.c | 209 +++++++++++++
> drivers/net/dsa/realtek/rtl83xx-qos.h | 20 ++
> include/net/ieee8021q.h | 21 +-
> net/core/ieee8021q_helpers.c | 103 ++++++-
> 10 files changed, 979 insertions(+), 22 deletions(-)
> ---
> base-commit: fa5196392691051963726787944db872420dfa75
> change-id: 20261109-rtl8365mb-dcb-ingress-0dae31a02c0f
>
> Best regards,
> --
> Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
>