Re: [PATCH v3 2/2] leds: lm3532: Avoid duplicate error messages

[Lee Jones]

On Wed, 21 Oct 2026, phucduc.bui@xxxxxxxxx wrote:

> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> Most error paths in lm3532_parse_node() already log errors. Remove
> the redundant error message from lm3532_probe() to avoid duplicate
> logs.
>
> Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>
> ---
>
> Link v1 : 
> https://lore.kernel.org/all/20261007104915.507801-1-phucduc.bui@xxxxxxxxx/
> Link v2 : 
> https://lore.kernel.org/all/20261009091059.25729-1-phucduc.bui@xxxxxxxxx/
>
> Changes in v3:
>  - Remove the error message for devm_add_action() failures.
>
>  drivers/leds/leds-lm3532.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/leds/leds-lm3532.c b/drivers/leds/leds-lm3532.c
> index a3bc9680dc4c..a050e4350bdb 100644
> --- a/drivers/leds/leds-lm3532.c
> +++ b/drivers/leds/leds-lm3532.c
> @@ -708,10 +708,8 @@ static int lm3532_probe(struct i2c_client *client)
>  	i2c_set_clientdata(client, drvdata);
>
>  	ret = lm3532_parse_node(drvdata);
> -	if (ret) {
> -		dev_err(&client->dev, "Failed to parse node\n");
> +	if (ret)
>  		return ret;
> -	}
>
>  	return ret;

As requested on v2, just:

    return lm3532_parse_node(drvdata);

>  }
> -- 
> 2.43.0
>
>

-- 
Lee Jones