Re: [PATCH net v4 2/2] xfrm: fix selector matching for IPv6 atomic fragments

From: Steffen Klassert

Date: Fri Nov 13 2026 - 08:23:59 EST


On Thu, Nov 12, 2026 at 02:33:35PM +0100, Jérémy Jean wrote:
> On 2026-11-12 14:20, Florian Westphal wrote:
> > Jérémy Jean <Jeremy.Jean@xxxxxxxxxxxxxxxxx> wrote:
> > > + if ((flkeys.control.flags & FLOW_DIS_IS_FRAGMENT) &&
> > > + ipv6_find_hdr(skb, &offset, -1, NULL, &fh_flags) >= 0 &&
> > > + (fh_flags & IP6_FH_F_FRAG) &&
> > > + !(fh_flags & IP6_FH_F_NON_ATOMIC)) {
> >
> > Since you need to send a new version anyway, maybe avoid
> > double-neg, i.e.: (fh_flags & IP6_FH_F_ATOMIC) ?
>
> Thanks for the advice, I will consider this for the next iteration.

When resending, please make sure to also Cc the new ipsec mailing list
so that the ipsec patchwork can track it:

ipsec@xxxxxxxxxxxxxxx

Thanks!